debug: complinace #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary changes for NCS CI. - compliance: Add an additional check for sauce tags. Also, since, in the code, we refer to Kconfig symbols that are defined in the sdk-nrf repository, the Kconfig check will not pass. Use KconfigBasic instead, which will not grep the code for instances of CONFIG_. - Add a Jenkinsfile. - Extend the max commit line lengths for Gitlint. Signed-off-by: Carles Cufi <[email protected]> (cherry picked from commit 83f7974)
This commit sets `ZEPHYR_<MODULE_NAME>_KCONFIG` variable for each Kconfig file discovered in `nrf/modules/<module>/Kconfig`. This is not meant as a permanent solution; we should do more careful consideration on the optimal approach forward that will allow compliance_check.py to be used downstream with custom module_ext_roots, and at the same time keep current flexibility for module glue code handling intact. Signed-off-by: Torsten Rasmussen <[email protected]> Signed-off-by: Martí Bolívar <[email protected]> (cherry picked from commit ad7f60e)
West update cannot import submanifests because the repo is checked out as "sdk-zephyr". This patch sets the checkout dir to "zephyr" in a variety of places where that's required for NCS. Signed-off-by: Maciej Perkowski <[email protected]> Signed-off-by: Martí Bolívar <[email protected]> (cherry picked from commit 75a8006) (cherry picked from commit 9f76a85)
Add some socket options and address family extensions to Zephyr headers, which will be useful for nRF Connect SDK. The "author" of this commit is a contact person; various people with s-o-b lines following here have contributed to the maintenance of this patch. Signed-off-by: Andreas Moltumyr <[email protected]> Signed-off-by: Andrzej Głąbek <[email protected]> Signed-off-by: Christopher Métrailler <[email protected]> Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Emanuele Di Santo <[email protected]> Signed-off-by: Glenn Ruben Bakke <[email protected]> Signed-off-by: Håkon Alseth <[email protected]> Signed-off-by: Ioannis Glaropoulos <[email protected]> Signed-off-by: Jan Tore Guggedal <[email protected]> Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Martí Bolívar <[email protected]> Signed-off-by: Mirko Covizzi <[email protected]> Signed-off-by: Petri Honkala <[email protected]> Signed-off-by: Robert Lubos <[email protected]> Signed-off-by: Tommi Mammela <[email protected]> Signed-off-by: Trond Einar Snekvik <[email protected]> (cherry picked from commit 55d7718) (cherry picked from commit d4cde89)
Provides an option to enable TLS session caching for an MQTT client's secure socket. Signed-off-by: Jan Tore Guggedal <[email protected]> Signed-off-by: Robert Lubos <[email protected]> Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Johann Fischer <[email protected]> (cherry picked from commit ab16331)
Adaptations of the upstream driver to use secure services and TF-M. This commit allows the setting of ieee802154 EUI64 address in the non-secure build by reading the FICR or UICR registers out of the secure zone. When CONFIG_BUILD_WITH_TFM=y, use tfm_platform_mem_read() to read EUI64 from the non-secure zone. Include secure_services.h header only if SPM=y. Signed-off-by: Czeslaw Makarski <[email protected]> Signed-off-by: Eduardo Montoya <[email protected]> Signed-off-by: Andrzej Głąbek <[email protected]> Signed-off-by: Damian Krolik <[email protected]> (cherry picked from commit 1a6d50b)
Add depends on !IS_SPM in config FPU. depends on !FPU gives a Kconfig dependency loop. This is not meant as a permanent solution. Signed-off-by: Øyvind Rønningstad <[email protected]> (cherry picked from commit 26c6ff3)
SPM is the default for NCS. Revert an nRF9160-DK change to ensure that SPM is set for NCS. Similarly, the configuration for samples with non-secure nrf5340 is not supported. Ref: NCSDK-9282 Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Johann Fischer <[email protected]> Signed-off-by: Andrzej Głąbek <[email protected]> Signed-off-by: Martí Bolívar <[email protected]> Signed-off-by: Håkon Øye Amundsen <[email protected]> (cherry picked from commit fe16863)
NOTE: This is a workaround to avoid a regression. There is a regression in nrf_security with regards to building BL2 and Crypto Services making the BL2 non-functional. This will be resolved later. Signed-off-by: Øyvind Rønningstad <[email protected]> (cherry picked from commit 2671126)
Hopefully, this change can be dropped at some point when code is reworked. Override some configuration settings. Signed-off-by: Frank Audun Kvamtrø <[email protected]> Signed-off-by: Torsten Rasmussen <[email protected]> (cherry picked from commit 92b131a)
Enable dynamic power control in hci_pwr_ctrl sample for platforms using hci_rpmsg as controller Signed-off-by: Azizah Ibrahim <[email protected]> Signed-off-by: Trond Einar Snekvik <[email protected]> (cherry picked from commit 194c111)
Update Kconfig options for qualification: - Remove experimental on qualified feature. - Add experimental on unqualified feature. Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Trond Einar Snekvik <[email protected]> Signed-off-by: Martí Bolívar <[email protected]> Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 3f7a45c)
Partition Manager (PM) is a component of the nRF Connect SDK (NCS) which uses yaml files to resolve flash partition placement with a holistic view of the entire device, including each firmware image present on the flash device, and various subsystems, such as settings and NFFS. When this NCS extension is used, various source files which would use partition information from devicetree in "vanilla" zephyr instead use defines generated by PM instead. This commit removes support for HEX_FILES_TO_MERGE, as it conflicts with PM. The settings subsystem pm.yml defines a partition 'settings_storage'. The nffs subsystem pm.yml defines 'nffs_storage'. Leverage label translation to avoid patching partition names. Refer to the NCS documentation page for this feature for more details. This is a long-running out of tree patch which has been worked on by several people. The following sign-offs are in alphabetical order by first name. Signed-off-by: Andrzej Głąbek <[email protected]> Signed-off-by: Andrzej Puzdrowski <[email protected]> Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Håkon Øye Amundsen <[email protected]> Signed-off-by: Ioannis Glaropoulos <[email protected]> Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Johann Fischer <[email protected]> Signed-off-by: Martí Bolívar <[email protected]> Signed-off-by: Ole Sæther <[email protected]> Signed-off-by: Robert Lubos <[email protected]> Signed-off-by: Sebastian Bøe <[email protected]> Signed-off-by: Sigvart Hovland <[email protected]> Signed-off-by: Thomas Stenersen <[email protected]> Signed-off-by: Torsten Rasmussen <[email protected]> Signed-off-by: Øyvind Rønningstad <[email protected]> Signed-off-by: Trond Einar Snekvik <[email protected]> (cherry picked from commit 32b99c7) (cherry picked from commit 30f63cb) (cherry picked from commit c1017afdf66982c039dc6d77d21b9d4fba477abc)
This is a noup patch because driver support is NCS-only. Add compatibles for CC310 and CC312 NS access. These downstream-only compatibles allow accessing the cryptocell from non-secure code. Use these, as well as pre-existing nodes for accessing the hardware directly from the secure world, in the relevant <soc>.dtsi files. Signed-off-by: Martí Bolívar <[email protected]> Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Frank Audun Kvamtrø <[email protected]> Signed-off-by: Ioannis Glaropoulos <[email protected]> Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 6a68834)
Increase the python recursion limit from 1k to 5k. See python comment for details. Signed-off-by: Sebastian Bøe <[email protected]>
-Adds Kconfig.psa -Add standardized algorithms, curve types etc as Kconfig variables -Add configurations for internal logic to see if a feature is enabled by PSA_WANTS_XXX ref: NCSDK-11689 Signed-off-by: Frank Audun Kvamtrø <[email protected]>
-This allows configurations enabled by PSA_WANTS_ALG_XXXX to be used to control which TF-M module is enabled -If the TF-M image doesn't support e.g. the MAC APIs, then the MAC interface is not enabled Note: This functionality requires that nrf_security is enabled ref: NCSDK-11689 Signed-off-by: Frank Audun Kvamtrø <[email protected]>
Set CRYPTO_HW_ACCELERATOR=True. This prevents a mulitple definition error between TF-M and nrf_security. Signed-off-by: Sebastian Bøe <[email protected]>
Make PPI channels used by softdevice visible to nrfx_glue. Signed-off-by: Azizah Ibrahim <[email protected]>
Implemented an option to use asyncronous uart api (CONFIG_NET_PPP_ASYNC_UART). From zephyrproject-rtos/zephyr#41649 Signed-off-by: Jani Hirsimäki <[email protected]>
GPIOTE channel was not freed when pin was reconfigured. This lead to channel pool draining when pin was frequently reconfigured. Signed-off-by: Krzysztof Chruscinski <[email protected]>
MPU9250 driver for 9-axis gyroscope, accelerometer, magnetometer Signed-off-by: Dominik Chat <[email protected]>
Use value returned by atomic_inc to decide on action. Previously direct value was used and that could lead to delays in logging processing because thread waking up could be mishandled. merged: zephyrproject-rtos/zephyr#41490 Signed-off-by: Krzysztof Chruscinski <[email protected]>
When message is dropped then log_process is called with bypass flag set and additionally z_log_dropped() is called. In both functions counter of buffered messages was decremented. That resulted in counter being decremented twice. It resulted in logging misbehavior after messages being dropped (delayed processing). Fixing it by decrementing the counter in log_process only when bypass flag is not set. Merged: zephyrproject-rtos/zephyr#41490 Signed-off-by: Krzysztof Chruscinski <[email protected]>
19e4e12 Testing shows cmake is invoked directly, not through a shell. Fixes commit 5092541 ("sanitycheck: disable erroring on warnings"). Note EXTRA_AFLAGS was quoted only on the left side! Signed-off-by: Marc Herbert <[email protected]>
Updated uart_rx_enable() and uart_tx() to use timeout given in microseconds. Previously argument was given in milliseconds. API change was done in: zephyrproject-rtos/zephyr#39041 Signed-off-by: Jani Hirsimäki <[email protected]>
Use extlink for GitHub issue links in documentation. Signed-off-by: Henrik Brix Andersen <[email protected]> (cherry picked from commit 2c0e0a7)
LaTeX code generated by Sphinx causes problems when using extlinks in references. Mitigate the problem by just using the extlink role directly. Signed-off-by: Gerard Marull-Paretas <[email protected]> (cherry picked from commit d253847)
The function `zephyr_linker_sources()` states: > When placing into NOINIT, RWDATA, RODATA, ROM_START, the contents of > the files will be placed inside an output section, so assume the > section definition is already present. However, in the posix linker.ld template the NOINIT, RWDATA, RODATA, and ROM_START was not placed inside a pre-defined output section, which means that linker scripts created for native_posix when `zephyr_linker_sources()` is used are invalid This result in the following failure: > /usr/bin/ld:zephyr/linker_zephyr_prebuilt.cmd:81: syntax error > collect2: error: ld returned 1 exit status This PR fixes this issue be predefining output sections according to the documented behavior. Signed-off-by: Torsten Rasmussen <[email protected]>
This commit updates the ieee802154 driver to match the current feature set of the nRF 802.15.4 radio driver for nRF53 SoCs. Signed-off-by: Jedrzej Ciupis <[email protected]> (cherry picked from commit 81ea529)
…one event Fix missing use of auxiliary context to generate done event which caused leak in release of auxiliary context being not release when reference count that should decrease to zero. Regression in 'commit 665a8d2 ("Bluetooth: Controller: Fix repeated per sync drift compensations"). Signed-off-by: Vinayak Kariappa Chettimada <[email protected]> (cherry picked from commit c2dda09) (cherry picked from commit 7a53a6d)
…t of LLL sched Fix missing auxiliary context release message on abort of LLL scheduling scheduling used by scan context. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]> (cherry picked from commit 7f24d3b) (cherry picked from commit 343972f)
…ng lll_disable Fix race condition in setting up ISR callback and parameter caused between ULL_HIGH and LLL context. As LLL IRQ is not disabled the parameter and ISR callback would get out of sync causing incorrect parameter supplied to callback and hence leading to development assert in ull_scan_done(). Signed-off-by: Vinayak Kariappa Chettimada <[email protected]> (cherry picked from commit d367447) (cherry picked from commit 073483a)
Fix to use non-discardable Rx buffer for handling Extended and Periodic Advertising Report. Regression introduced in commit 18171bc ("Bluetooth: Host: Non-discardable event buffer size is 255 for ext adv"). The default discardable Rx buffer size was reduced causing increased fragmentation and deadlock trying to get more free discardable Rx buffers to generate HCI Extended and Periodic Advertising reports. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]> (cherry picked from commit 230f4f1) (cherry picked from commit 901604f)
…onnected callback" This reverts commit 0a1f553. Signed-off-by: Marek Pieta <[email protected]> (cherry picked from commit 5c3fc27)
…rs for CTE RX There were used an uninitialized variable to set antenna identifiers length. The value should be set with use of params argument, not by cp pointer that is not yet initialized. Signed-off-by: Piotr Pryga <[email protected]> (cherry picked from commit c889e34)
squash! [nrf fromlist] twister: add option to create shorter build paths This changes was introduced to this open Upstream PR: zephyrproject-rtos/zephyr#41930 Signed-off-by: Piotr Golyzniak <[email protected]>
The path was erroneously pointing to update state resource instead of update result causing a wrong resource value to be updated. Signed-off-by: Jarno Lamsa <[email protected]>
Use kernel print function to reduce the memory impact. Signed-off-by: Jarno Lamsa <[email protected]>
squash! [nrf noup] ci: NCS-specific CI tweaks A shortlog that looks like "[nrf noup]: foo: bar" has shown up in real life and should fail this compliance test, but it doesn't. Fix that by checking for an explicit space after the closing "]" in a sauce tag. Signed-off-by: Martí Bolívar <[email protected]>
This fix a typo where incorrect member of bt_keys was used for checking if LTK is present. This was resulting in bogus results depending on connection role and current identity used. This was affecting L2CAP/LE/CFC/BV-25-C qualification test case. Fixes: #42862 Signed-off-by: Szymon Janc <[email protected]> Signed-off-by: Ilhan Ates <[email protected]> (cherry-pick of 4fce6fb)
Uninitialized memory would report wrong value for `mAckedWithSecEnhAck` flag in the received frame, making the OpenThread stack to update the frame counter for the neighbor wrongly. Signed-off-by: Eduardo Montoya <[email protected]> (cherry picked from commit 19ac4d818fe6f43b27864f1564e4894b0a23f1bd)
…nd of errors Fix bug in radio implementation that reported any transmit error as `OT_ERROR_NO_ACK` to OpenThread. Signed-off-by: Eduardo Montoya <[email protected]> (cherry picked from commit a0093ee)
If OPENTHREAD_IP6_FRAGM is enabled the IPv6 fragments are handled in OpenThread stack but also forwarder unconditionally to the Zephyr uplayers. It causes additional packets processing and leads to errors like unrecognized next header type or duplicate ping reply. What more these errors generate additional traffic which jam channel and decrease latency for packets required fragmentation. This commit add filtering IPv6 fragments when data fragmentation and reassembling is enabled in OpenThread. Signed-off-by: Lukasz Maciejonczyk <[email protected]> (cherry picked from commit c9effd0)
Sphinx 4.33.0 introduces Graphviz support, but the Graphviz configuration value names clash with the Sphinx built-in Graphviz extension. Issue: breathe-doc/breathe#803 Signed-off-by: Gerard Marull-Paretas <[email protected]> (cherry picked from commit 8889114)
Looks like the 4.33 release has some more issues, so let's wait until everything gets fixed before allowing future versions. Ref. breathe-doc/breathe#805 Signed-off-by: Gerard Marull-Paretas <[email protected]> (cherry picked from commit 10da718)
If a central disconnects an ISO, then the `chan` pointer will become NULL before attempting to call the disconnect callback. Signed-off-by: Emil Gydesen <[email protected]>
The conn pointer is still valid / not reused at this time and can be used further up the stack as an identifer. This simplifies the API of ATT, and fixes callbacks in GATT that pass on this value directly since their API does not allow conn to be NULL. Fixes #41794 Signed-off-by: Aleksander Wasaznik <[email protected]>
PerMac
force-pushed
the
debug/compliance
branch
4 times, most recently
from
7636f41 to
4d0ae2b
Compare
squash! [nrf noup] ci: NCS-specific CI tweaks In nrf we changed Kconfig check to KconfigBasic but the workflow was not changed to scan for the KconfigBasic.txt file which is generated in place of Kconfig.txt . compliance debug Signed-off-by: Maciej Perkowski <[email protected]>
PerMac
force-pushed
the
debug/compliance
branch
from
4d0ae2b to
af07090
Compare
PerMac
force-pushed
the
main
branch
2 times, most recently
from
74c7bca to
60166d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
39 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compliance debug
Signed-off-by: Maciej Perkowski [email protected]