Skip to content

fix: module auto install #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025
Merged

Conversation

ThbPS
Copy link
Collaborator

@ThbPS ThbPS commented Jun 12, 2025

Questions Answers
Description? Module name is not listed by unzip, so we need to extract it to get the module name. For example, postaldeliv/controllers is used instead of postaldeliv to install the module. Module installation fail because postaldeliv/controllers is not a valid module name.
Type? bug fix
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes #{issue URL here}, Fixes #{another issue URL here}
How to test? Test with module postaldeliv version 8.0.4

BC breaks

Use alpine3.21 instead of latest alpine docker image to fix PHP 8.1, 8.2 and 8.3 extensions compilation because in ICU versions higher than 74.0 some C++ headers are not included
See php/php-src#18831 (comment)

@ThbPS ThbPS changed the title fix: module install fix: module auto install Jun 12, 2025
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Jun 12, 2025
Copy link

@Alexandre-Lematre Alexandre-Lematre merged commit 924cd45 into PrestaShop:main Jun 17, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants