Prefer single quotes when possible

src/bin/compile

@@ -2,7 +2,7 @@
 <?php
 
 if ((!@include __DIR__ . '/../../../../autoload.php') && (!@include __DIR__ . '/../../vendor/autoload.php')) {
-    die("You must set up the project dependencies, run composer install");
+    die('You must set up the project dependencies, run composer install');
 }
 
 use QafooLabs\Refactoring\Adapters\Symfony\Compiler;

src/bin/refactor

@@ -2,7 +2,7 @@
 <?php
 
 if ((!@include __DIR__ . '/../../../../autoload.php') && (!@include __DIR__ . '/../../vendor/autoload.php')) {
-    die("You must set up the project dependencies, run composer install");
+    die('You must set up the project dependencies, run composer install');
 }
 
 use QafooLabs\Refactoring\Adapters\Symfony\CliApplication;

src/main/QafooLabs/Refactoring/Adapters/PHPParser/ParserPhpNameScanner.php

@@ -22,7 +22,7 @@ public function findNames(File $file)
         try {
             $stmts = $parser->parse($file->getCode());
         } catch (\PHPParser\Error $e) {
-            throw new \RuntimeException("Error parsing " . $file->getRelativePath() .": " . $e->getMessage(), 0, $e);
+            throw new \RuntimeException('Error parsing ' . $file->getRelativePath() . ': ' . $e->getMessage(), 0, $e);
         }
 
         $traverser->addVisitor($collector);

src/main/QafooLabs/Refactoring/Adapters/PHPParser/ParserVariableScanner.php

@@ -44,7 +44,7 @@ public function scanForVariables(File $file, LineRange $range)
         $selectedStatements = $collector->getStatements();
 
         if ( ! $selectedStatements) {
-            throw new \RuntimeException("No statements found in line range.");
+            throw new \RuntimeException('No statements found in line range.');
         }
 
         $localVariableClassifier = new LocalVariableClassifier();

src/main/QafooLabs/Refactoring/Adapters/PHPParser/Visitor/LocalVariableClassifier.php

@@ -68,7 +68,7 @@ private function enterAssignment(Node\Expr\Assign $node)
 
     private function enterVariableNode(Node\Expr\Variable $node)
     {
-        if ($node->name === "this" || $this->seenAssignmentVariables->contains($node)) {
+        if ($node->name === 'this' || $this->seenAssignmentVariables->contains($node)) {
             return;
         }
 

src/main/QafooLabs/Refactoring/Adapters/TokenReflection/StaticCodeAnalysis.php

@@ -45,7 +45,7 @@ public function getMethodEndLine(File $file, LineRange $range)
         $method = $this->findMatchingMethod($file, $range);
 
         if ($method === null) {
-            throw new \InvalidArgumentException("Could not find method end line.");
+            throw new \InvalidArgumentException('Could not find method end line.');
         }
 
         return $method->getEndLine();
@@ -56,7 +56,7 @@ public function getMethodStartLine(File $file, LineRange $range)
         $method = $this->findMatchingMethod($file, $range);
 
         if ($method === null) {
-            throw new \InvalidArgumentException("Could not find method start line.");
+            throw new \InvalidArgumentException('Could not find method start line.');
         }
 
         return $method->getStartLine();
@@ -67,7 +67,7 @@ public function getFunctionEndLine(File $file, LineRange $range)
         $function = $this->findMatchingFunction($file, $range);
 
         if ($function === null) {
-            throw new \InvalidArgumentException("Could not find function end line.");
+            throw new \InvalidArgumentException('Could not find function end line.');
         }
 
         return $function->getEndLine();
@@ -78,7 +78,7 @@ public function getFunctionStartLine(File $file, LineRange $range)
         $function = $this->findMatchingFunction($file, $range);
 
         if ($function === null) {
-            throw new \InvalidArgumentException("Could not find function start line.");
+            throw new \InvalidArgumentException('Could not find function start line.');
         }
 
         return $function->getStartLine();
@@ -105,7 +105,7 @@ public function getLineOfLastPropertyDefinedInScope(File $file, $lastLine)
             }
         }
 
-        throw new \InvalidArgumentException("Could not find method start line.");
+        throw new \InvalidArgumentException('Could not find method start line.');
     }
 
     public function isInsideMethod(File $file, LineRange $range)

src/main/QafooLabs/Refactoring/Domain/Model/Directory.php

@@ -64,7 +64,7 @@ public function findAllPhpFilesRecursivly()
                             RecursiveIteratorIterator::LEAVES_ONLY
                         ),
                         function (SplFileInfo $file) {
-                            return substr($file->getFilename(), -4) === ".php";
+                            return substr($file->getFilename(), -4) === '.php';
                         }
                     ),
                     function ($file) use ($workingDirectory) {

src/main/QafooLabs/Refactoring/Domain/Model/File.php

@@ -30,12 +30,12 @@ class File
     public static function createFromPath($path, $workingDirectory)
     {
         if ( ! file_exists($path) || ! is_file($path)) {
-            throw new \InvalidArgumentException("Not a valid file: " . $path);
+            throw new \InvalidArgumentException('Not a valid file: ' . $path);
         }
 
         $code = file_get_contents($path);
         $workingDirectory = rtrim($workingDirectory, '/\\');
-        $relativePath = ltrim(str_replace($workingDirectory, "", $path), "/\\");
+        $relativePath = ltrim(str_replace($workingDirectory, '', $path), "/\\");
 
         // converted mixed, wrapped, absolute paths on windows
         if (DIRECTORY_SEPARATOR === '\\' && strpos($relativePath, '://') !== FALSE) {
@@ -92,7 +92,7 @@ public function extractPsr0ClassName()
 
     private function parseFileForPsr0ClassShortName()
     {
-        return str_replace(".php", "", $this->getBaseName());
+        return str_replace('.php', '', $this->getBaseName());
     }
 
     private function parseFileForPsr0NamespaceName()
@@ -119,7 +119,7 @@ private function parseFileForPsr0NamespaceName()
 
         array_pop($namespace);
 
-        return str_replace(".php", "", implode("\\", $namespace));
+        return str_replace('.php', '', implode("\\", $namespace));
     }
 
     private function startsWithLowerCase($string)

src/main/QafooLabs/Refactoring/Domain/Model/LineRange.php

@@ -51,7 +51,7 @@ static public function fromLines($start, $end)
      */
     static public function fromString($range)
     {
-        list($start, $end) = explode("-", $range);
+        list($start, $end) = explode('-', $range);
 
         return self::fromLines($start, $end);
     }

src/main/QafooLabs/Refactoring/Domain/Model/MethodSignature.php

@@ -47,7 +47,7 @@ private function change($flags)
         }
 
         if ( ! in_array(($flags & $visibility), $allowedVisibilities)) {
-            throw new \InvalidArgumentException("Mix of visibilities is not allowed.");
+            throw new \InvalidArgumentException('Mix of visibilities is not allowed.');
         }
 
         return $flags;

src/main/QafooLabs/Refactoring/Domain/Model/PhpName.php

@@ -184,7 +184,7 @@ public function __toString()
 
     public function hashCode()
     {
-        return "1373136332" . $this->fullyQualifiedName . $this->relativeName;
+        return '1373136332' . $this->fullyQualifiedName . $this->relativeName;
     }
 
     public function fullyQualified()

src/main/QafooLabs/Refactoring/Domain/Model/PhpNameChange.php

@@ -38,6 +38,6 @@ public function change(PhpName $name)
 
     public function hashCode()
     {
-        return "1373136290" . $this->fromName->hashCode() . $this->toName->hashCode();
+        return '1373136290' . $this->fromName->hashCode() . $this->toName->hashCode();
     }
 }

src/main/QafooLabs/Refactoring/Utils/ValueObject.php

@@ -23,13 +23,13 @@ abstract class ValueObject
 {
     final public function __set($name, $value)
     {
-        throw new \BadmethodCallException("Cannot set values on a value object.");
+        throw new \BadmethodCallException('Cannot set values on a value object.');
     }
 
     public function __get($name)
     {
         if ( ! isset($this->$name)) {
-            throw new \RuntimeException(sprintf("Variable %s does not exist on %s.", $name,  get_class($this)));
+            throw new \RuntimeException(sprintf('Variable %s does not exist on %s.', $name,  get_class($this)));
         }
 
         return $this->$name;

src/test/QafooLabs/Refactoring/Adapters/PHPParser/ParserPhpNameScannerTest.php

@@ -31,7 +31,7 @@ public function testFindNames()
 
     public function testRegressionFindNamesDetectsFQCNCorrectly()
     {
-        $file = new File("Fqcn.php", <<<'PHP'
+        $file = new File('Fqcn.php', <<<'PHP'
 <?php
 
 namespace Bar;
@@ -69,7 +69,7 @@ function ($occurance) {
 
     public function testFindNamesFindsParentForPhpNameInSingleLineUseStatement()
     {
-        $file = new File("Fqcn.php", <<<'PHP'
+        $file = new File('Fqcn.php', <<<'PHP'
 <?php
 
 use Bar\Qux\Adapter;
@@ -97,7 +97,7 @@ public function testFindNamesFindsParentForPhpNameInSingleLineUseStatement()
 
     public function testFindNamesFindsParentForPhpNameInMultiLineUseStatement()
     {
-        $file = new File("Fqcn.php", <<<'PHP'
+        $file = new File('Fqcn.php', <<<'PHP'
 <?php
 
 use Bar\Qux\Adapter,

src/test/QafooLabs/Refactoring/Adapters/PHPParser/Visitor/LineRangeStatementCollectorTest.php

@@ -18,7 +18,7 @@ public function givenNestedStatements_WhenCollecting_ThenOnlyCollectTopLevel()
     {
         $stmts = $this->statements('$this->foo(bar(baz()));');
 
-        $collector = new LineRangeStatementCollector($this->range("2-2"));
+        $collector = new LineRangeStatementCollector($this->range('2-2'));
 
         $this->traverse($stmts, $collector);
 
@@ -54,7 +54,7 @@ private function range($range)
 
     private function statements($code)
     {
-        if (strpos($code, "<?php") === false) {
+        if (strpos($code, '<?php') === false) {
             $code = "<?php\n" . $code;
         }
 

src/test/QafooLabs/Refactoring/Adapters/PHPParser/Visitor/LocalVariableClassifierTest.php

@@ -10,7 +10,7 @@ class LocalVariableClassifierTest extends \PHPUnit_Framework_TestCase
     public function givenVariable_WhenClassification_ThenLocalVariableFound()
     {
         $classifier = new LocalVariableClassifier();
-        $variable = new \PHPParser_Node_Expr_Variable("foo");
+        $variable = new \PHPParser_Node_Expr_Variable('foo');
 
         $classifier->enterNode($variable);
 
@@ -24,8 +24,8 @@ public function givenAssignment_WhenClassification_ThenAssignmentFound()
     {
         $classifier = new LocalVariableClassifier();
         $assign = new \PHPParser_Node_Expr_Assign(
-            new \PHPParser_Node_Expr_Variable("foo"),
-            new \PHPParser_Node_Expr_Variable("bar")
+            new \PHPParser_Node_Expr_Variable('foo'),
+            new \PHPParser_Node_Expr_Variable('bar')
         );
 
         $classifier->enterNode($assign);
@@ -40,8 +40,8 @@ public function givenAssignmentAndReadOfSameVariable_WhenClassification_ThenFind
     {
         $classifier = new LocalVariableClassifier();
         $assign = new \PHPParser_Node_Expr_Assign(
-            new \PHPParser_Node_Expr_Variable("foo"),
-            new \PHPParser_Node_Expr_Variable("foo")
+            new \PHPParser_Node_Expr_Variable('foo'),
+            new \PHPParser_Node_Expr_Variable('foo')
         );
 
         $traverser     = new \PHPParser_NodeTraverser;
@@ -58,7 +58,7 @@ public function givenAssignmentAndReadOfSameVariable_WhenClassification_ThenFind
     public function givenThisVariable_WhenClassification_ThenNoLocalVariables()
     {
         $classifier = new LocalVariableClassifier();
-        $variable = new \PHPParser_Node_Expr_Variable("this");
+        $variable = new \PHPParser_Node_Expr_Variable('this');
 
         $classifier->enterNode($variable);
 
@@ -71,7 +71,7 @@ public function givenThisVariable_WhenClassification_ThenNoLocalVariables()
     public function givenParam_WhenClassification_FindAsAssignment()
     {
         $classifier = new LocalVariableClassifier();
-        $variable = new \PHPParser_Node_Param("foo");
+        $variable = new \PHPParser_Node_Param('foo');
 
         $classifier->enterNode($variable);
 
@@ -88,9 +88,9 @@ public function givenArrayDimFetchASsignment_WhenClassification_FindAsAssignment
 
         $assign = new \PHPParser_Node_Expr_Assign(
             new \PHPParser_Node_Expr_ArrayDimFetch(
-                new \PHPParser_Node_Expr_Variable("foo")
+                new \PHPParser_Node_Expr_Variable('foo')
             ),
-            new \PHPParser_Node_Expr_Variable("bar")
+            new \PHPParser_Node_Expr_Variable('bar')
         );
 
         $classifier->enterNode($assign);

src/test/QafooLabs/Refactoring/Application/RenameLocalVariableTest.php

@@ -33,7 +33,7 @@ public function testRenameLocalVariable()
         \Phake::when($this->editor)->openBuffer(\Phake::anyParameters())->thenReturn($buffer);
         \Phake::when($this->codeAnalysis)->findMethodRange(\Phake::anyParameters())->thenReturn(LineRange::fromSingleLine(1));
 
-        $patch = $this->refactoring->refactor(new File("foo.php", <<<'PHP'
+        $patch = $this->refactoring->refactor(new File('foo.php', <<<'PHP'
 <?php
 class Foo
 {
@@ -53,7 +53,7 @@ public function testRenameNonLocalVariable_ThrowsException()
         $this->setExpectedException('QafooLabs\Refactoring\Domain\Model\RefactoringException', 'Given variable "$this->foo" is required to be local to the current method.');
 
         $this->refactoring->refactor(
-            new File("foo.php", ''), 6,
+            new File('foo.php', ''), 6,
             new Variable('$this->foo'),
             new Variable('$foo')
         );
@@ -64,7 +64,7 @@ public function testRenameIntoNonLocalVariable_ThrowsException()
         $this->setExpectedException('QafooLabs\Refactoring\Domain\Model\RefactoringException', 'Given variable "$this->foo" is required to be local to the current method.');
 
         $this->refactoring->refactor(
-            new File("foo.php", ''), 6,
+            new File('foo.php', ''), 6,
             new Variable('$foo'),
             new Variable('$this->foo')
         );

src/test/QafooLabs/Refactoring/Application/Service/ExtractMethodTest.php

@@ -28,7 +28,7 @@ public function setUp()
      */
     public function testRefactorSimpleMethod()
     {
-        $patch = $this->refactoring->refactor(new File("foo.php", <<<'PHP'
+        $patch = $this->refactoring->refactor(new File('foo.php', <<<'PHP'
 <?php
 class Foo
 {
@@ -38,7 +38,7 @@ public function main()
     }
 }
 PHP
-            ), LineRange::fromString("6-6"), "helloWorld");
+            ), LineRange::fromString('6-6'), 'helloWorld');
 
 
         \Phake::verify($this->applyCommand)->apply(<<<'CODE'
@@ -69,7 +69,7 @@ public function testVariableUsedBeforeAndAfterExtractedSlice()
     {
         $this->markTestIncomplete('Failing over some invisible whitespace issue?');
 
-        $patch = $this->refactoring->refactor(new File("foo.php", <<<'PHP'
+        $patch = $this->refactoring->refactor(new File('foo.php', <<<'PHP'
 <?php
 class Foo
 {
@@ -85,7 +85,7 @@ public function main()
     }
 }
 PHP
-            ), LineRange::fromString("9-10"), "extract");
+            ), LineRange::fromString('9-10'), 'extract');
 
 
         \Phake::verify($this->applyCommand)->apply(<<<'CODE'

src/test/QafooLabs/Refactoring/Domain/Model/LineRangeTest.php

@@ -17,7 +17,7 @@ public function testCreateFromSingleLine()
 
     public function testCreateFromString()
     {
-        $range = LineRange::fromString("1-4");
+        $range = LineRange::fromString('1-4');
 
         $this->assertEquals(1, $range->getStart());
         $this->assertEquals(4, $range->getEnd());

src/test/QafooLabs/Refactoring/Domain/Model/MethodSignatureTest.php

@@ -9,7 +9,7 @@ class MethodSignatureTest extends \PHPUnit_Framework_TestCase
      */
     public function whenCreateMethodSignatureWithDefaults_ThenIsPrivateAndNotStatic()
     {
-        $method = new MethodSignature("foo");
+        $method = new MethodSignature('foo');
 
         $this->assertTrue($method->isPrivate());
         $this->assertFalse($method->isStatic());
@@ -20,17 +20,17 @@ public function whenCreateMethodSignatureWithDefaults_ThenIsPrivateAndNotStatic(
      */
     public function whenCreateMethodSignatureWithInvalidVisibility_ThenThrowException()
     {
-        $this->setExpectedException("InvalidArgumentException");
+        $this->setExpectedException('InvalidArgumentException');
 
-        $method = new MethodSignature("foo", MethodSignature::IS_PRIVATE | MethodSignature::IS_PUBLIC);
+        $method = new MethodSignature('foo', MethodSignature::IS_PRIVATE | MethodSignature::IS_PUBLIC);
     }
 
     /**
      * @test
      */
     public function whenCreateMethodSignatureWithStaticOnly_ThenAssumePrivateVisibility()
     {
-        $method = new MethodSignature("foo", MethodSignature::IS_STATIC);
+        $method = new MethodSignature('foo', MethodSignature::IS_STATIC);
 
         $this->assertTrue($method->isPrivate());
         $this->assertTrue($method->isStatic());