Skip to content

feat: implement useAsyncComputed$ #7589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2025
Merged

feat: implement useAsyncComputed$ #7589

merged 9 commits into from
Jun 2, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented May 13, 2025

The current implementation should be a replacement for useComputed$ with a promise. The loading and error fields are implmented, but are hidden and probably not working yet. This should be merged for the v2 beta

@Varixo Varixo self-assigned this May 13, 2025
Copy link

changeset-bot bot commented May 13, 2025

🦋 Changeset detected

Latest commit: 72ba9f9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented May 13, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7589
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7589
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7589
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7589

commit: 72ba9f9

Copy link
Contributor

github-actions bot commented May 13, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 72ba9f9

@Varixo Varixo force-pushed the v2-use-async-computed branch 5 times, most recently from 2f580ab to 1163e3d Compare May 14, 2025 14:06
@Varixo Varixo moved this from Backlog to In progress in Qwik Development May 14, 2025
@Varixo Varixo force-pushed the v2-use-async-computed branch 5 times, most recently from 930f3c2 to dfb595f Compare May 20, 2025 16:01
@Varixo Varixo force-pushed the v2-use-async-computed branch from 6fda763 to efa7461 Compare May 24, 2025 11:37
@Varixo Varixo force-pushed the v2-use-async-computed branch from efa7461 to 6821854 Compare May 24, 2025 11:51
@Varixo Varixo changed the title WIP feat: implement useAsyncComputed$ feat: implement useAsyncComputed$ Jun 2, 2025
@Varixo Varixo moved this from In progress to Waiting For Review in Qwik Development Jun 2, 2025
@Varixo Varixo marked this pull request as ready for review June 2, 2025 15:14
@Varixo Varixo requested review from a team as code owners June 2, 2025 15:14
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👯

@Varixo Varixo force-pushed the v2-use-async-computed branch from a28ad19 to aaa4de4 Compare June 2, 2025 16:30
@Varixo Varixo force-pushed the v2-use-async-computed branch from aaa4de4 to 72ba9f9 Compare June 2, 2025 16:34
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@wmertens wmertens merged commit c918d2b into build/v2 Jun 2, 2025
19 checks passed
@wmertens wmertens deleted the v2-use-async-computed branch June 2, 2025 17:26
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants