chore: merge main into v2 #7651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the error is not helpful and it's nicer to just check and ignore
…rfile [docs] Add comments to the Dockerfile
test: pass context to config hook
- don't assume path of bundlegraph during render - move bundlegraph to standard assets location - refactor preloader script output
this allows knowing all the needed files for offline apps
- the bundlegraph asset is not relative to build/ - the resolved manifest in the server only has a selection of manifest keys
Removed concurrently in favor of pnpm parallel execution
Update index.mdx ## Summary This PR addresses a TypeScript error related to the use of readonly tuple types in conjunction with QRL. ## Problem Using a readonly tuple type A extends readonly unknown[] caused the following TypeScript diagnostic when invoking a QRL: Argument of type '[...A]' is not assignable to parameter of type 'QrlArgs<(...args: A) => R>'. [2345] ## Root Cause This appears to be a type compatibility issue between the readonly tuple spread ([...A]) and the expected QrlArgs type in the QRL function signature. It's possible there's an edge case or mismatch in how QrlArgs<(...args: A) => R> resolves in the presence of readonly tuples, or perhaps recent TypeScript updates introduced stricter rules around readonly spreads. ## Solution The fix involves removing the readonly modifier from the generic tuple constraint: - A extends readonly unknown[] + A extends unknown[] This ensures compatibility with the QRL's expected argument types while preserving type safety. ### Notes Further investigation might be warranted to confirm whether this is a TypeScript typing nuance or a limitation in the Qwik QRL typings themselves.
* Add typescript-plugin-css-modules typescript plugin for css modules * Configure tsconfig.json for css modules plugin * fix syntax error * Add comment to tsconfig.json
* fix(rollup): call fileName hook with assetsDir and debug:true * chore: changeset
chore(noSerialize): don't console when bad value
Document more thoroughly the use case for useContent with current page's headings
fix: bundlegraph as regular asset
🦋 Changeset detectedLatest commit: e8e553f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
caused repl segments to no longer show
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.