Migrate to planus from flatc #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some syntax changes have been made.
.itemFloattype no longer exists.PyFloatgets stored until.pack()is called, at which point theflat::Floatis constructed automatically. This only applies to the state setting code whereFloatwas used:Non-forward facing changes:
Planus, a Rust implementation of the flatbuffers compiler with an emphasis on generating high-quality Rust code, is now used. The intermediate representation of the flatbuffers spec is used by the codegen script to generate the additional Python code, which is now ran through
cargo fmtbefore being written to the disk.The use of Planus's IR of the flatbuffers spec provides ergonomic access to all the data in a manor that's been heavily tested and verified against lots of inputs vs the old, custom sudo-parser.