Prepare for generating school codes (#348)

Author: chrisroos

app/controllers/admin/schools_controller.rb

@@ -2,41 +2,28 @@
 
 module Admin
   class SchoolsController < Admin::ApplicationController
-    def authorized_action?(resource, action)
-      case action
-      when :verify_school
-        resource&.rejected_at.present? || resource&.verified_at.nil?
-      when :reject_school
-        resource&.verified_at.present? || resource&.rejected_at.nil?
-      else
-        super
-      end
-    end
-
-    def verify_school
-      school_id = params[:school_id]
-      service = SchoolVerificationService.new(school_id)
+    def verify
+      service = SchoolVerificationService.new(requested_resource)
 
       if service.verify
         flash[:notice] = t('administrate.controller.verify_school.success')
       else
         flash[:error] = t('administrate.controller.verify_school.error')
       end
 
-      redirect_to admin_school_path(id: school_id)
+      redirect_to admin_school_path(requested_resource)
     end
 
-    def reject_school
-      school_id = params[:school_id]
-      service = SchoolVerificationService.new(school_id)
+    def reject
+      service = SchoolVerificationService.new(requested_resource)
 
       if service.reject
         flash[:notice] = t('administrate.controller.reject_school.success')
       else
         flash[:error] = t('administrate.controller.reject_school.error')
       end
 
-      redirect_to admin_school_path(id: school_id)
+      redirect_to admin_school_path(requested_resource)
     end
 
     def default_sorting_attribute

app/models/school.rb

@@ -17,6 +17,10 @@ class School < ApplicationRecord
   validates :creator_id, presence: true, uniqueness: true
   validates :creator_agree_authority, presence: true, acceptance: true
   validates :creator_agree_terms_and_conditions, presence: true, acceptance: true
+  validates :rejected_at, absence: { if: proc { |school| school.verified? } }
+  validates :verified_at, absence: { if: proc { |school| school.rejected? } }
+  validate :verified_at_cannot_be_changed
+  validate :rejected_at_cannot_be_changed
 
   before_validation :normalize_reference
 
@@ -31,10 +35,34 @@ def creator
     User.from_userinfo(ids: creator_id).first
   end
 
+  def verified?
+    verified_at.present?
+  end
+
+  def rejected?
+    rejected_at.present?
+  end
+
+  def verify!
+    update!(verified_at: Time.zone.now)
+  end
+
+  def reject
+    update(rejected_at: Time.zone.now)
+  end
+
   private
 
   # Ensure the reference is nil, not an empty string
   def normalize_reference
     self.reference = nil if reference.blank?
   end
+
+  def verified_at_cannot_be_changed
+    errors.add(:verified_at, 'cannot be changed after verification') if verified_at_was.present? && verified_at_changed?
+  end
+
+  def rejected_at_cannot_be_changed
+    errors.add(:rejected_at, 'cannot be changed after rejection') if rejected_at_was.present? && rejected_at_changed?
+  end
 end

app/models/teacher_invitation.rb

@@ -16,7 +16,7 @@ class TeacherInvitation < ApplicationRecord
   private
 
   def school_is_verified
-    return if school.verified_at
+    return if school.verified?
 
     errors.add(:school, 'is not verified')
   end

app/services/school_verification_service.rb

@@ -1,27 +1,27 @@
 # frozen_string_literal: true
 
 class SchoolVerificationService
-  def initialize(school_id)
-    @school_id = school_id
+  attr_reader :school
+
+  def initialize(school)
+    @school = school
   end
 
+  # rubocop:disable Metrics/AbcSize
   def verify
     School.transaction do
-      school = School.find(@school_id)
-      school.update(verified_at: Time.zone.now, rejected_at: nil)
+      school.verify!
       Role.owner.create(user_id: school.creator_id, school:)
       Role.teacher.create(user_id: school.creator_id, school:)
     end
   rescue StandardError => e
     Sentry.capture_exception(e)
-    Rails.logger.error { "Failed to verify school #{school_id}: #{e.message}" }
+    Rails.logger.error { "Failed to verify school #{@school_id}: #{e.message}" }
     false
   else
     true
   end
+  # rubocop:enable Metrics/AbcSize
 
-  def reject
-    school = School.find(@school_id)
-    school.update(verified_at: nil, rejected_at: Time.zone.now)
-  end
+  delegate :reject, to: :school
 end

app/views/admin/schools/show.html.erb

@@ -32,21 +32,21 @@ as well as a link to its edit page.
 
     <%= link_to(
       t("administrate.actions.verify_school"),
-      admin_school_verify_school_path(page.resource),
+      verify_admin_school_path(page.resource),
       class: "button button--verify",
       method: :post,
       style: "background-color: green; margin: 5px;",
       data: { confirm: t("administrate.actions.confirm_verify_school") }
-    ) if accessible_action?(page.resource, :verify_school) %>
+    ) unless page.resource.verified? || page.resource.rejected? %>
 
     <%= link_to(
       t("administrate.actions.reject_school"),
-      admin_school_reject_school_path(page.resource),
+      reject_admin_school_path(page.resource),
       class: "button button--danger",
       method: :patch,
       style: "background-color: hsla(0, 88%, 33%, 1); margin: 5px 5px 5px 0;",
       data: { confirm: t("administrate.actions.confirm_reject_school") }
-    ) if accessible_action?(page.resource, :reject_school) %>
+    ) unless page.resource.verified? || page.resource.rejected? %>
   </div>
 </header>
 

config/routes.rb

@@ -11,8 +11,10 @@
     end
 
     resources :schools, only: %i[index show edit update] do
-      post :verify_school, action: :verify_school
-      patch :reject_school, action: :reject_school
+      member do
+        post :verify
+        patch :reject
+      end
     end
 
     resources :school_classes, only: %i[show]

lib/concepts/school_owner/invite.rb

@@ -18,7 +18,7 @@ def call(school:, school_owner_params:, token:)
       def invite_owner(school, school_owner_params, token)
         email_address = school_owner_params.fetch(:email_address)
 
-        raise ArgumentError, 'school is not verified' unless school.verified_at
+        raise ArgumentError, 'school is not verified' unless school.verified?
         raise ArgumentError, "email address '#{email_address}' is invalid" unless EmailValidator.valid?(email_address)
 
         ProfileApiClient.invite_school_owner(token:, email_address:, organisation_id: school.id)

lib/concepts/school_student/create.rb

@@ -27,7 +27,7 @@ def create_student(school, school_student_params, token)
       end
 
       def validate(school:, username:, password:, name:)
-        raise ArgumentError, 'school is not verified' unless school.verified_at
+        raise ArgumentError, 'school is not verified' unless school.verified?
         raise ArgumentError, "username '#{username}' is invalid" if username.blank?
         raise ArgumentError, "password '#{password}' is invalid" if password.size < 8
         raise ArgumentError, "name '#{name}' is invalid" if name.blank?

lib/concepts/school_student/create_batch.rb

@@ -30,7 +30,7 @@ def create_batch(school, uploaded_file, token)
       def validate(school:, sheet:)
         expected_header = ['Student Name', 'Username', 'Password']
 
-        raise ArgumentError, 'school is not verified' unless school.verified_at
+        raise ArgumentError, 'school is not verified' unless school.verified?
         raise ArgumentError, 'the spreadsheet header row is invalid' unless sheet.row(1) == expected_header
 
         @errors = []

lib/tasks/classroom_management_helper.rb

@@ -25,7 +25,7 @@ def create_school(creator_id, school_id = nil)
 
   def verify_school(school)
     Rails.logger.info 'Verifying the school...'
-    SchoolVerificationService.new(school.id).verify
+    SchoolVerificationService.new(school).verify
   end
 
   def create_school_class(teacher_id, school)

spec/concepts/school_owner/invite_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe SchoolOwner::Invite, type: :unit do
   let(:token) { UserProfileMock::TOKEN }
-  let(:school) { create(:school, verified_at: Time.zone.now) }
+  let(:school) { create(:verified_school) }
   let(:owner_id) { SecureRandom.uuid }
 
   let(:school_owner_params) do

spec/concepts/school_student/create_batch_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe SchoolStudent::CreateBatch, type: :unit do
   let(:token) { UserProfileMock::TOKEN }
-  let(:school) { create(:school, verified_at: Time.zone.now) }
+  let(:school) { create(:verified_school) }
   let(:file) { fixture_file_upload('students.csv') }
 
   before do

spec/concepts/school_student/create_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe SchoolStudent::Create, type: :unit do
   let(:token) { UserProfileMock::TOKEN }
-  let(:school) { create(:school, verified_at: Time.zone.now) }
+  let(:school) { create(:verified_school) }
 
   let(:school_student_params) do
     {

spec/concepts/school_teacher/invite_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe SchoolTeacher::Invite, type: :unit do
   let(:token) { UserProfileMock::TOKEN }
-  let(:school) { create(:school, verified_at: Time.zone.now) }
+  let(:school) { create(:verified_school) }
   let(:teacher_id) { SecureRandom.uuid }
 
   let(:school_teacher_params) do