Skip to content

[🚀 Feature]: [dotnet] [bidi] Avoid Modules namespace #15791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nvborisenko opened this issue May 24, 2025 · 6 comments
Closed

[🚀 Feature]: [dotnet] [bidi] Avoid Modules namespace #15791

nvborisenko opened this issue May 24, 2025 · 6 comments
Labels
A-needs-triaging A Selenium member will evaluate this soon! I-enhancement Something could be better

Comments

@nvborisenko
Copy link
Member

nvborisenko commented May 24, 2025

Description

OpenQA.Selenum.BiDi namespace:

Image

Have you considered any alternatives or workarounds?

What if we simplify Modules namespace? And move up?

Personally I don't expect files/folders will be increased.

@nvborisenko nvborisenko added I-enhancement Something could be better A-needs-triaging A Selenium member will evaluate this soon! labels May 24, 2025
@selenium-ci
Copy link
Member

@nvborisenko, thank you for creating this issue. We will troubleshoot it as soon as we can.

Selenium Triage Team: remember to follow the Triage Guide

@nvborisenko
Copy link
Member Author

@RenderMichael @YevgeniyShunevych this one is a breaking change (and it is fine while we are in beta phase). What do you think? Personally I feel we applied good patterns in BiDi namespace and I don't expect we will introduce much more. So just to simplify for users:
Before:

OpenQA.Selenium.BiDi.Modules.Network

After:

OpenQA.Selenium.BiDi.Network

I would like to simplify earlier rather than later (or never).

@YevgeniyShunevych
Copy link
Contributor

I completely support reducing the number of namespaces, cutting off sub-namespaces. Grouping source files with folder structures is great, and it doesn't require each folder to have its own namespace, even though IDE builds such namespace by default. I often try to keep all types within a single project/library with the single namespace. It mostly has no sense to keep many namespaces within a single library. For WebDriver it would be good to keep all BiDi-related stuff within OpenQA.Selenium.BiDi namespace.

@YevgeniyShunevych
Copy link
Contributor

Also, for years I don't understand the .NET WebDriver project naming problem.

  1. The package is Selenium.WebDriver
  2. The library is WebDriver.dll
  3. The default namespace is OpenQA.Selenium

From my point of view, it would be great at some major release point to name all 3 things as Selenium.WebDriver.

@nvborisenko
Copy link
Member Author

Thanks Yevgeniy, at least 2 people agree what is better. I will do it.

About naming, it is also confusing me. And also your proposed naming matches my expectation: Selenium.WebDriver package, Selenium.WebDriver.csproj, Selenium.WebDriver.dll (breaking change here), OpenQA.Selenium.WebDriver default namespace (not sure we should change it even in major release).

@nvborisenko
Copy link
Member Author

Done, thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-needs-triaging A Selenium member will evaluate this soon! I-enhancement Something could be better
Projects
None yet
Development

No branches or pull requests

4 participants