-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[dotnet] [bidi] Simplify modules namespace for end users (breaking change) #15820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Pretty big, but it really simplifies things. Thanks Nick. |
User description
🔗 Related Issues
#15791
💥 What does this PR do?
Avoid
Modules
namespace:Before:
After:
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement, Bug fix
Description
Flattened BiDi module namespaces for end users
Modules
namespace from BiDi submodulesRefactored internal and test code to use new namespaces
Introduced a new
Key.cs
file inInput
(stub, commented)This is a breaking change for consumers of the BiDi .NET API
Changes walkthrough 📝
152 files
Remove `Modules` namespace from BiDi submodules and usages
Move BrowserModule to flattened namespace
Move ClientWindow to flattened namespace
Move ClientWindowInfo to flattened namespace
Move CloseCommand to flattened namespace
Move CreateUserContextCommand to flattened namespace
Move GetClientWindowsCommand to flattened namespace
Move GetUserContextsCommand to flattened namespace
Move RemoveUserContextCommand to flattened namespace
Move UserContext to flattened namespace
Move UserContextInfo to flattened namespace
Move ActivateCommand to flattened namespace
Move BrowsingContext to flattened namespace
Move BrowsingContextInfo to flattened namespace
Move BrowsingContextInputModule to flattened namespace
Move BrowsingContextLogModule to flattened namespace
Move BrowsingContextModule to flattened namespace
Move BrowsingContextNetworkModule to flattened namespace
Move BrowsingContextScriptModule to flattened namespace
Move BrowsingContextStorageModule to flattened namespace
Move CaptureScreenshotCommand to flattened namespace
Move CloseCommand to flattened namespace
Move CreateCommand to flattened namespace
Move GetTreeCommand to flattened namespace
Move HandleUserPromptCommand to flattened namespace
Move LocateNodesCommand to flattened namespace
Move Locator to flattened namespace
Move NavigateCommand to flattened namespace
Move Navigation to flattened namespace
Move NavigationInfo to flattened namespace
Move PrintCommand to flattened namespace
Move ReloadCommand to flattened namespace
Move SetViewportCommand to flattened namespace
Move TraverseHistoryCommand to flattened namespace
Move UserPromptClosedEventArgs to flattened namespace
Move UserPromptOpenedEventArgs to flattened namespace
Update logger and Subscription types for new namespaces
Update EventHandler to use flattened BrowsingContext
Update all JsonSerializable types to flattened namespaces
Update using to flattened Browser namespace
Update using to flattened Browser namespace
Update BrowsingContextConverter to flattened namespace
Update using to flattened Script namespace
Update using to flattened Browser namespace
Update using to flattened Storage and Network namespaces
Update using to flattened Script namespace
Update using to flattened Browser namespace
Update using to flattened Input namespace
Update using to flattened BrowsingContext and Script namespaces
Update using to flattened Script namespace
Update using to flattened Input namespace
Update using to flattened Network namespace
Update using to flattened Script namespace
Update using to flattened BrowsingContext namespace
Update using to flattened Script namespace
Update LogEntryConverter to flattened Log namespace
Update using to flattened Script namespace
Update using to flattened Script namespace
Update using to flattened Script namespace
Update using to flattened BrowsingContext namespace
Update using to flattened Script namespace
Update using to flattened Script namespace
Update using to flattened Network namespace
Update SubscriptionConverter to flattened Session namespace
Update logger to use Internal.Logging.Log
Update BrowsingContextEventArgs to flattened namespace
Move InputModule to flattened namespace
Move Origin to flattened namespace
Move PerformActionsCommand to flattened namespace
Move ReleaseActionsCommand to flattened namespace
Move SetFilesCommand to flattened namespace
Move SourceActions to flattened namespace
Move LogEntry to flattened namespace
Move LogModule to flattened namespace
Move Module base class to flattened namespace
Move AddInterceptCommand to flattened namespace
Move AuthChallenge to flattened namespace
Move AuthCredentials to flattened namespace
Move AuthRequiredEventArgs to flattened namespace
Move BaseParametersEventArgs to flattened namespace
Move BeforeRequestSentEventArgs to flattened namespace
Move BytesValue to flattened namespace
Move ContinueRequestCommand to flattened namespace
Move ContinueResponseCommand to flattened namespace
Move ContinueWithAuthCommand to flattened namespace
Move Cookie to flattened namespace
Move CookieHeader to flattened namespace
Move FailRequestCommand to flattened namespace
Move FetchErrorEventArgs to flattened namespace
Move FetchTimingInfo to flattened namespace
Move Header to flattened namespace
Move Initiator to flattened namespace
Move Intercept to flattened namespace
Move NetworkModule.HighLevel to flattened namespace
Move NetworkModule to flattened namespace
Move ProvideResponseCommand to flattened namespace
Move RemoveInterceptCommand to flattened namespace
Move Request to flattened namespace
Move RequestData to flattened namespace
Move ResponseCompletedEventArgs to flattened namespace
Move ResponseContent to flattened namespace
Move ResponseData to flattened namespace
Move ResponseStartedEventArgs to flattened namespace
Move SetCacheBehaviorCommand to flattened namespace
Move SetCookieHeader to flattened namespace
Move UrlPattern to flattened namespace
Move AddPreloadScriptCommand to flattened namespace
Move CallFunctionCommand to flattened namespace
Move Channel to flattened namespace
Move ChannelProperties to flattened namespace
Move DisownCommand to flattened namespace
Move EvaluateCommand to flattened namespace
Move GetRealmsCommand to flattened namespace
Move Handle to flattened namespace
Move IRemoteReference to flattened namespace
Move InternalId to flattened namespace
Move LocalValue to flattened namespace
Move MessageEventArgs to flattened namespace
Move NodeProperties to flattened namespace
Move PreloadScript to flattened namespace
Move Realm to flattened namespace
Move RealmDestroyedEventArgs to flattened namespace
Move RealmInfo to flattened namespace
Move RealmType to flattened namespace
Move RegExpValue to flattened namespace
Move RemoteValue to flattened namespace
Move RemovePreloadScriptCommand to flattened namespace
Move ResultOwnership to flattened namespace
Move ScriptModule to flattened namespace
Move SerializationOptions to flattened namespace
Move Source to flattened namespace
Move StackFrame to flattened namespace
Move StackTrace to flattened namespace
Move Target to flattened namespace
Move WindowProxyProperties to flattened namespace
Move CapabilitiesRequest to flattened namespace
Move CapabilityRequest to flattened namespace
Move EndCommand to flattened namespace
Move NewCommand to flattened namespace
Move ProxyConfiguration to flattened namespace
Move SessionModule to flattened namespace
Move StatusCommand to flattened namespace
Move SubscribeCommand to flattened namespace
Move Subscription to flattened namespace
Move UnsubscribeCommand to flattened namespace
Move UserPromptHandler to flattened namespace
Move DeleteCookiesCommand to flattened namespace
Move GetCookiesCommand to flattened namespace
Move PartitionKey to flattened namespace
Move SetCookieCommand to flattened namespace
Move StorageModule to flattened namespace
Update Subscription to use flattened Session namespace
2 files
Add new (commented) Key.cs file in Input
Update commented namespace to flattened Input
15 files
Update BiDiFixture to use flattened BrowsingContext
Remove old using, rely on flattened namespace
Update usings to flattened BrowsingContext
Update using to flattened BrowsingContext
Update LogTest to use flattened Log/Script types
Update usings to flattened BrowsingContext
Update usings to flattened BrowsingContext
Remove old using, rely on flattened namespace
Update usages to flattened BrowsingContext
Remove old using, rely on flattened namespace
Update usages to flattened BrowsingContext
Remove old using, rely on flattened namespace
Update usages to flattened BrowsingContext/Log types
Update usages to flattened BrowsingContext
Update using to flattened Network namespace