Skip to content

[py] Remove unused xfail on chrome/edge service tests #15637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Apr 18, 2025

User description

💥 What does this PR do?

This PR removes the xfail_chrome PyTest marker from the following tests:

py/test/selenium/webdriver/edge/edge_service_tests.py::test_uses_edgedriver_logging
py/test/selenium/webdriver/edge/edge_service_tests.py::::test_uses_chromedriver_logging

These tests were fixed in #15605 and #15579 and run properly now.

(The marker wasn't working correctly anyway)


PR Type

Bug fix, Tests


Description

  • Removed unused xfail_chrome marker from Chrome service test.

  • Removed unused xfail_edge marker from Edge service test.

  • Cleaned up test files for Chrome and Edge services.


Changes walkthrough 📝

Relevant files
Tests
chrome_service_tests.py
Removed unused `xfail_chrome` marker in Chrome tests         

py/test/selenium/webdriver/chrome/chrome_service_tests.py

  • Removed xfail_chrome marker from a test.
  • Simplified test annotations for Chrome service.
  • +0/-2     
    edge_service_tests.py
    Removed unused `xfail_edge` marker in Edge tests                 

    py/test/selenium/webdriver/edge/edge_service_tests.py

  • Removed xfail_edge marker from a test.
  • Simplified test annotations for Edge service.
  • +0/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @selenium-ci selenium-ci added the C-py Python Bindings label Apr 18, 2025
    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @cgoldberg cgoldberg merged commit 8c9aa17 into SeleniumHQ:trunk Apr 18, 2025
    7 checks passed
    @cgoldberg cgoldberg deleted the py-remove-xfail branch April 18, 2025 02:24
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants