-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[rb] handle issue with selenium manager exit status being nil #15676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit 67bdb18)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
🔗 Related Issues
Fixes #14622
💥 What does this PR do?
nil
🔧 Implementation Notes
Decided to log note (at info level) instead of just handling the nil so if it errors the user gets additional understanding, and if it doesn't error it still notes that the code is going through an unexpected process.
💡 Additional Considerations
None
🔄 Types of changes
PR Type
Bug fix, Tests
Description
Refactored Selenium Manager command execution and error handling
Added and updated unit tests for new error handling logic
Changes walkthrough 📝
selenium_manager.rb
Refactor and improve Selenium Manager command error handling
rb/lib/selenium/webdriver/common/selenium_manager.rb
selenium_manager_spec.rb
Add tests for improved Selenium Manager error handling
rb/spec/unit/selenium/webdriver/common/selenium_manager_spec.rb