-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[py] Missing Headers Assignment in Network Class’s _on_request() #15736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This solves #15735 |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
User description
🔗 Related Issues
#15735
💥 What does this PR do?
Addresses missing header assignment discovered in #15735 using https://w3c.github.io/webdriver-bidi/#module-network-definition
🔄 Types of changes
PR Type
Bug fix
Description
Fixes missing
headers
assignment in Network class's_on_request
Ensures request headers are properly captured in BiDi events
Changes walkthrough 📝
network.py
Add missing headers assignment in BiDi Network event handling
py/selenium/webdriver/common/bidi/network.py
headers
from event data to Request object in_on_request
callback.network events.