Skip to content

Fix: Added Fixes For Dark Theme #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Rupak182
Copy link

Related Issue
Fixes #660

Description of Changes

  • Overridden CSS parameter for typography plugin to follow theme colors
  • Modified DataVisualizationWidget.jsx to behave according to default or dark theme
  • Modified TableViewerWidget.jsx. to behave according to default or dark theme

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • New example
  • Test improvement

Testing

Fix.mp4

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run my code against examples and ensured no errors
  • Any dependent changes have been merged and published in downstream modules

Additional Information
Appropriate changes should to be made if extra themes are added other than dark theme that is provided by tailwind using dark class.

@amrutha97 amrutha97 force-pushed the main branch 2 times, most recently from 6ac1dad to bdb2c4e Compare April 24, 2025 07:54
@shivam-singhal
Copy link
Member

@Rupak182 Can you test this exhaustively across all components (e.g. in preswald/tutorial)?

@Rupak182
Copy link
Author

Rupak182 commented Apr 25, 2025

@shivam-singhal I already tested before creating the pull request for all examples in /examples directory. Had to make some changes for DAGVisualizationWidget.jsx for preswald/tutorial example. as it uses custom styles for DAG component. Still , one image component is not getting displayed as it depends on the image source which in this case is already dark in color.

Screen.Recording.2025-04-25.122429.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dark Theme is not getting applied to all the elements
2 participants