Skip to content

Credit Card Validation Support #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Credit Card Validation Support #217

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c911c77
added credit card number validation support
quacklabs Mar 8, 2019
437bd63
added cardparser
quacklabs Mar 8, 2019
15d04f7
Fixed validation return error on creditCardRule
quacklabs Mar 8, 2019
0a77de4
fixed card returning invalid due to spaces
quacklabs Mar 8, 2019
9c1bb96
fixed card returning invalid due to spaces
quacklabs Mar 8, 2019
bdc64c1
fixed card returning invalid due to spaces
quacklabs Mar 8, 2019
6389105
Changed Readme to notify of CardParser Library
quacklabs Mar 8, 2019
df7748f
created Unit tests for card number validation
quacklabs Mar 8, 2019
73d89ae
Fixed credit card number validation build test
quacklabs Mar 8, 2019
27c2742
testing card validation
quacklabs Mar 8, 2019
168a5b0
resolved group linking causing build errors
quacklabs Mar 8, 2019
bd3eb11
fixed Unit tests and folder group for xcode
quacklabs Mar 9, 2019
4aaa5e7
Merge pull request #1 from quacklabs/card_validation
quacklabs Mar 9, 2019
f99a46c
Card Expiry Date in full (eg: 10/12) rule added
quacklabs Mar 15, 2019
91ef7c3
minor fixes in comments
quacklabs Mar 15, 2019
4bf4306
Merge pull request #2 from quacklabs/card_validation
quacklabs Mar 15, 2019
c0e5af7
removed comment line
quacklabs Mar 18, 2019
8aacb35
Merge pull request #3 from quacklabs/card_validation
quacklabs Mar 18, 2019
fe3a1db
fixed month not validating past November
quacklabs Mar 18, 2019
86714d2
Merge pull request #4 from quacklabs/card_validation
quacklabs Mar 18, 2019
4d61e5c
added checks for blank card expiry date causing crash
quacklabs Mar 18, 2019
65e98b2
Merge pull request #5 from quacklabs/card_validation
quacklabs Mar 18, 2019
dc2ada4
fixed endIndex error in expiry date validation
quacklabs Mar 18, 2019
039b2cd
Merge pull request #6 from quacklabs/card_validation
quacklabs Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed comment line
  • Loading branch information
@quacklabs
quacklabs committed Mar 18, 2019
commit c0e5af70f90ec9c9250234c67bd8655ffb2b61ff
1 change: 0 additions & 1 deletion SwiftValidator/Rules/CardExpiryRule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ public class CardExpiryRule: Rule {
public func validate(_ value: String) -> Bool {
let date = value.replacingOccurrences(of: "/", with: "")
let Index = date.index(date.startIndex, offsetBy: 2)
//let yearIndex = date.index(date.endIndex, offsetBy: -2)
let Month = Int(date[..<Index])
let Year = Int(date[Index...])

Expand Down