Skip to content

added ridge regression #12250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
7 changes: 6 additions & 1 deletion machine_learning/ridge_regression/model.py
Original file line number Diff line number Diff line change
@@ -1,31 +1,33 @@
import numpy as np

Check failure on line 1 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (INP001)

machine_learning/ridge_regression/model.py:1:1: INP001 File `machine_learning/ridge_regression/model.py` is part of an implicit namespace package. Add an `__init__.py`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred while parsing the file: machine_learning/ridge_regression/model.py

Traceback (most recent call last):
  File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
    reports = lint_file(
              ^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 1:1.
tokenizer error: no matching outer block for dedent

import numpy as np
^

import pandas as pd


class RidgeRegression:
def __init__(self, alpha:float=0.001, regularization_param:float=0.1, num_iterations:int=1000) -> None:

Check failure on line 6 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

machine_learning/ridge_regression/model.py:6:89: E501 Line too long (107 > 88)
self.alpha:float = alpha
self.regularization_param:float = regularization_param
self.num_iterations:int = num_iterations
self.theta:np.ndarray = None


def feature_scaling(self, X:np.ndarray) -> tuple[np.ndarray, np.ndarray, np.ndarray]:

Check failure on line 13 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N803)

machine_learning/ridge_regression/model.py:13:31: N803 Argument name `X` should be lowercase

Check failure on line 13 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

machine_learning/ridge_regression/model.py:13:89: E501 Line too long (89 > 88)
mean = np.mean(X, axis=0)
std = np.std(X, axis=0)

# avoid division by zero for constant features (std = 0)
std[std == 0] = 1 # set std=1 for constant features to avoid NaN

X_scaled = (X - mean) / std

Check failure on line 20 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N806)

machine_learning/ridge_regression/model.py:20:9: N806 Variable `X_scaled` in function should be lowercase

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_scaled

return X_scaled, mean, std


def fit(self, X:np.ndarray, y:np.ndarray) -> None:

Check failure on line 24 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N803)

machine_learning/ridge_regression/model.py:24:19: N803 Argument name `X` should be lowercase
X_scaled, mean, std = self.feature_scaling(X)

Check failure on line 25 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N806)

machine_learning/ridge_regression/model.py:25:9: N806 Variable `X_scaled` in function should be lowercase

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_scaled

m, n = X_scaled.shape
self.theta = np.zeros(n) # initializing weights to zeros


for i in range(self.num_iterations):

Check failure on line 30 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (B007)

machine_learning/ridge_regression/model.py:30:13: B007 Loop control variable `i` not used within loop body
predictions = X_scaled.dot(self.theta)
error = predictions - y

Expand All @@ -35,12 +37,14 @@
) / m
self.theta -= self.alpha * gradient # updating weights


def predict(self, X:np.ndarray) -> np.ndarray:

Check failure on line 41 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N803)

machine_learning/ridge_regression/model.py:41:23: N803 Argument name `X` should be lowercase
X_scaled, _, _ = self.feature_scaling(X)

Check failure on line 42 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N806)

machine_learning/ridge_regression/model.py:42:9: N806 Variable `X_scaled` in function should be lowercase

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_scaled

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: X_scaled

return X_scaled.dot(self.theta)


def compute_cost(self, X:np.ndarray, y:np.ndarray) -> float:
X_scaled, _, _ = self.feature_scaling(X)
X_scaled, _, _ = self.feature_scaling(X)
m = len(y)

predictions = X_scaled.dot(self.theta)
Expand All @@ -49,6 +53,7 @@
) * np.sum(self.theta**2)
return cost


def mean_absolute_error(self, y_true:np.ndarray, y_pred:np.ndarray) -> float:
return np.mean(np.abs(y_true - y_pred))

Expand Down