Skip to content

Fix parameter order in decision tree mse #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Fix parameter order in decision tree mse #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix MSE call in decision tree
  • Loading branch information
@alejandroaldas
alejandroaldas committed Jun 3, 2025
commit 73c285532706d470429dc2c5517b428269e3b0b3
2 changes: 1 addition & 1 deletion machine_learning/decision_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def train(self, x, y):
return

best_split = 0
min_error = self.mean_squared_error(x, np.mean(y)) * 2
min_error = self.mean_squared_error(y, np.mean(y)) * 2

"""
loop over all possible splits for the decision tree. find the best split.
Expand Down
Loading