ci: ci and cd jobs for utils ts distribution via verdacio; replacing bun with npm for root semantic release deps; #279
Conversation
…bun with npm for root semantic release deps;
aorumbayev
requested review from
PatrickDinh and
lempira
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR introduces CI/CD automation for TypeScript packages using Verdaccio as a private npm registry, and migrates from Bun to npm for semantic release dependencies.
- Adds TypeScript package build, test, and release workflow using Verdaccio
- Replaces Bun with npm for root semantic release dependencies across workflows
- Configures semantic release for TypeScript packages with npm publishing
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/typescript/release.config.cjs | Adds semantic release configuration for TypeScript packages |
| packages/typescript/package.json | Updates npm workspace commands and removes GitHub registry config |
| packages/typescript/algokit_utils/package.json | Removes GitHub package registry publish configuration |
| .github/workflows/typescript_ci_cd.yml | New reusable workflow for TypeScript CI/CD with Verdaccio integration |
| .github/workflows/python_uniffi_ci_cd.yml | Migrates from Bun to npm for semantic release |
| .github/workflows/ci_cd.yml | Integrates TypeScript CI/CD workflow into main pipeline |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
@joe-p any objections on removing bun from root? Noticed we still had it there and leveraged in python uniffi cd - but given that we moved from bun in typescript folder as well as in apis there is no need for bun in typescript cd. I replaced the root with npm instead of bun. Swift pipeline is untouched yet given its commented out anyway (would need moving to npm later on as well). |
| "@algorandfoundation/algokit-common": "../algokit_common/dist", | ||
| "@algorandfoundation/algokit-transact": "../algokit_transact/dist", | ||
| "@algorandfoundation/indexer-client": "../indexer_client/dist", | ||
| "@algorandfoundation/kmd-client": "../kmd_client/dist" |
There was a problem hiding this comment.
@lempira so just to confirm and recap - what should we use for the org prefix to the ts packages ? I havent renamed it from @algorandfoundation/algokit-utils yet. Once we agree on a name I would need to commit a rename across all occurences of @algorandfoundation relevant to the packages and commit a change before this is merged
| run: | | ||
| # Re-install to ensure dist folders are properly linked | ||
| npm install --prefer-offline --no-audit --no-fund | ||
| npm install --prefer-offline --no-fund |
There was a problem hiding this comment.
im removing these temporarily until we have a proper npm audit stage enforced
|
Hey @lempira any chance you can take a look? We would need the secrets set on the repo before we can merge the PR. Otherwise if you need more time for review and verdaccio setup would it be better to then split this pr into CI and CD parts as CI bit can be merged without waiting for verdaccio setup. |
3 participants
Tested with my tmp instance of verdaccio on a fork.
IMPORTANT: The following VERDACCIO_URL var and VERDACCIO_TOKEN secret must be set on repo prior to merging (cc @lempira )