fix(compute): lro samples (GoogleCloudPlatform#1361)

Fixing LRO for compute samples and adding region tag to extract the operation_check part for usage in quick start tutorial.

Please mind that delete_instance with wait can take up to 3 minutes, which slows down the whole test suite.

Author: rsamborski

compute/cloud-client/instances/src/create_instance.php

@@ -29,6 +29,7 @@
 use Google\Cloud\Compute\V1\AttachedDiskInitializeParams;
 use Google\Cloud\Compute\V1\Instance;
 use Google\Cloud\Compute\V1\NetworkInterface;
+use Google\Cloud\Compute\V1\Operation;
 use Google\Cloud\Compute\V1\ZoneOperationsClient;
 
 /**
@@ -80,7 +81,7 @@ function create_instance(
     $instancesClient = new InstancesClient();
     $operation = $instancesClient->insert($instance, $projectId, $zone);
 
-    if ($operation->getStatus() === 'RUNNING') {
+    if ($operation->getStatus() === Operation\Status::RUNNING) {
         // Wait until operation completes
         $operationClient = new ZoneOperationsClient();
         $operationClient->wait($operation->getName(), $projectId, $zone);

compute/cloud-client/instances/src/delete_instance.php

@@ -25,8 +25,12 @@
 
 # [START compute_instances_delete]
 use Google\Cloud\Compute\V1\InstancesClient;
+# [START compute_instances_operation_check]
+use Google\Cloud\Compute\V1\Operation;
 use Google\Cloud\Compute\V1\ZoneOperationsClient;
 
+# [END compute_instances_operation_check]
+
 /**
  * Creates an instance.
  * Example:
@@ -49,11 +53,17 @@ function delete_instance(
     $instancesClient = new InstancesClient();
     $operation = $instancesClient->delete($instanceName, $projectId, $zone);
 
-    if ($operation->getStatus() === 'RUNNING') {
+    # [START compute_instances_operation_check]
+    if ($operation->getStatus() === Operation\Status::RUNNING) {
         // Wait until operation completes
         $operationClient = new ZoneOperationsClient();
-        $operationClient->wait($operation->getName(), $projectId, $zone);
+
+        // Default timeout of 60s is not always enough for operation to finish,
+        // to avoid an exception we set timeout to 180000 ms = 180 s = 3 minutes
+        $optionalArgs = ['timeoutMillis' => 180000];
+        $operationClient->wait($operation->getName(), $projectId, $zone, $optionalArgs);
     }
+    # [END compute_instances_operation_check]
 
     printf('Deleted instance %s' . PHP_EOL, $instanceName);
 }