Skip to content

fix(compute): lro samples #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 5 commits into from
May 20, 2021
Merged

fix(compute): lro samples #1361

gcf-merge-on-green merged 5 commits into from
May 20, 2021

Conversation

@rsamborski
Copy link
Member

@rsamborski rsamborski commented May 20, 2021 •
edited
Loading

Fixing LRO for compute samples and adding region tag to extract the operation_check part for usage in quick start tutorial.

Please mind that delete_instance with wait can take up to 3 minutes, which slows down the whole test suite.

@rsamborski rsamborski added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels May 20, 2021
@rsamborski rsamborski requested a review from bshaffer May 20, 2021 14:17
@rsamborski rsamborski self-assigned this May 20, 2021
@rsamborski rsamborski requested a review from a team as a code owner May 20, 2021 14:17
@snippet-bot
Copy link

snippet-bot bot commented May 20, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2021
@rsamborski rsamborski mentioned this pull request May 20, 2021
Merged
@bshaffer bshaffer added the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2021
@bshaffer bshaffer changed the title Fix lro for compute samples fix(compute): lro samples May 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 570df40 into master May 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2021
@bshaffer bshaffer deleted the fix_lro_for_compute_samples branch May 20, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees

@rsamborski rsamborski

Labels

api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rsamborski @bshaffer