-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Unclear docs example for Dialog component #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@kara The code to fix this is probably outside of the scope of what the 'Git' touches. @devversion You seem to do the tooling, I think these issues are related. I would love to help but really cannot find the code that generates these issues. Not sure if this is you or @crisbeto See : These issues are related to #3002 but that is also missing additional files list in its definition in example-module.ts |
Tracking via angular/material.angular.io#165 |
great job! i have been working on the issue for a very long time when i was following the doc. your solution magically made it work!!! thanks |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Dialog with a result example in the docs is a little bit unclear in my opinion on how to return the value back to DialogResultExample component. If you open the plunker version, you can nicely see two .html files where it shows you that on close method you pass in the parameter. But in the docs version, there is only html for DialogResultExample component.
I am suggesting that the html tab for docs on this example would be like this:
P.S. also, the title of example is Dailog with a result (notice the typo for Dialog).
Btw, you are doing an amazing work on Angular Material!
The text was updated successfully, but these errors were encountered: