feat(cdk/drag-drop): introduce resetToBoundary
#30436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
naaajii
requested review from
mmalerba and
andrewseguin
and removed request for
a team
crisbeto
reviewed
Feb 12, 2025
src/cdk/drag-drop/drag-ref.ts
Outdated
| resetToBoundary(): void { | ||
| // can be null if the drag item was never dragged. | ||
| if (this._boundaryElement) { | ||
| let x = this._boundaryElement.offsetWidth - this._rootElement.offsetWidth, |
There was a problem hiding this comment.
I'm not sure I follow why we need the offset here, it seems like it just gets moved all the way to the right of the boundary. I think we should check if the element is outside the boundary and move it by the amount of overflow pixels.
There was a problem hiding this comment.
yes, I initially just moved it to the right of the boundary. I have made it calculate now offset of the overflown pixels. lemme know if this needs any more correction.
crisbeto
approved these changes
Apr 19, 2025
|
Looks like there's a merge conflicts in the API goldens. |
this commit introduces `resetToBoundary` in DragRef which allows user to align DragItem to its boundary on demand if at one point it was at a place where the boundary element used to be and has shrinked causing DragItem to be outside of the boundary box fixes angular#30325
crisbeto
approved these changes
Apr 20, 2025
crisbeto
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit introduces
resetToBoundaryin DragRef which allows user to align DragItem to its boundary on demand if at one point it was at a place where the boundary element used to be and has shrinked causing DragItem to be outside of the boundary boxfixes #30325