Skip to content

[PATCH] Migrate to use rules_js based ng_package #30940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 23, 2025

Conversation

josephperrott
Copy link
Member

Note: this is the second attempt to merge this change, it now includes a fix for the documentation site which can be verified with the preview deployment.

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase labels Apr 23, 2025
@josephperrott josephperrott requested a review from mmalerba April 23, 2025 17:01
@josephperrott josephperrott requested review from a team as code owners April 23, 2025 17:01
@josephperrott josephperrott requested review from adolgachev and removed request for a team and adolgachev April 23, 2025 17:01
@josephperrott josephperrott force-pushed the replace-ng-package-patch branch from f7c537c to aeb5e79 Compare April 23, 2025 17:02
@josephperrott josephperrott force-pushed the replace-ng-package-patch branch from aeb5e79 to 6e6fad4 Compare April 23, 2025 17:06
Copy link

Deployed dev-app for 6e6fad4 to: https://ng-dev-previews-comp--pr-angular-components-30940-dev-5iv6aubo.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link

Deployed docs-preview for 6e6fad4 to: https://ng-dev-previews-comp--pr-angular-components-30940-docs-6cn3gb90.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@josephperrott josephperrott removed the request for review from mmalerba April 23, 2025 18:15
@josephperrott josephperrott merged commit 54cc2cf into angular:19.2.x Apr 23, 2025
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants