fix(material/tabs): flicker when animationDuration is set to zero #30966
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tabs have a fallback that sets `transition-delay: 1ms` in case users disabled animations without going through one of our APIs. That was also applying when they set `animationDuration="0"` which is a supported API. The result was a slight flicker. These changes resolve the flicker by treating `animationDuration="0"` in the same way as if animations were disabled globally. Fixes angular#30964.
crisbeto
requested review from
adolgachev and
wagnermaciel
and removed request for
a team
andrewseguin
approved these changes
Apr 28, 2025
crisbeto
added
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 28, 2025
…gular#30966) The tabs have a fallback that sets `transition-delay: 1ms` in case users disabled animations without going through one of our APIs. That was also applying when they set `animationDuration="0"` which is a supported API. The result was a slight flicker. These changes resolve the flicker by treating `animationDuration="0"` in the same way as if animations were disabled globally. Fixes angular#30964.
crisbeto
added a commit
that referenced
this pull request
Apr 28, 2025
…0966) (#30968) The tabs have a fallback that sets `transition-delay: 1ms` in case users disabled animations without going through one of our APIs. That was also applying when they set `animationDuration="0"` which is a supported API. The result was a slight flicker. These changes resolve the flicker by treating `animationDuration="0"` in the same way as if animations were disabled globally. Fixes #30964.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tabs have a fallback that sets
transition-delay: 1msin case users disabled animations without going through one of our APIs. That was also applying when they setanimationDuration="0"which is a supported API. The result was a slight flicker.These changes resolve the flicker by treating
animationDuration="0"in the same way as if animations were disabled globally.Fixes #30964.