build: prevent markdown styling from bleeding into examples #31358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
Currently we style the content in the docs by setting a `docs-markdown` class around it which then targets element tags that can be produced by the markdown renderer like `p` and `h1`. The problem with this is that some components use these elements for their own styling, e.g. the main `mat-card` example looks off because its `p` tag styling is overridden by `docs-markdown`. These changes update the docs generation script to exclude the component styles from the markdown styles.
crisbeto
force-pushed
the
docs-paragraph-style
branch
from
9d2f82b to
e54429a
Compare
andrewseguin
approved these changes
Jun 14, 2025
|
The changes were merged into the following branches: main, 20.0.x |
crisbeto
added a commit
that referenced
this pull request
Jun 14, 2025
Currently we style the content in the docs by setting a `docs-markdown` class around it which then targets element tags that can be produced by the markdown renderer like `p` and `h1`. The problem with this is that some components use these elements for their own styling, e.g. the main `mat-card` example looks off because its `p` tag styling is overridden by `docs-markdown`. These changes update the docs generation script to exclude the component styles from the markdown styles. (cherry picked from commit c771a01)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we style the content in the docs by setting a
docs-markdownclass around it which then targets element tags that can be produced by the markdown renderer likepandh1. The problem with this is that some components use these elements for their own styling, e.g. the mainmat-cardexample looks off because itsptag styling is overridden bydocs-markdown.These changes update the docs generation script to exclude the component styles from the markdown styles.
Example of the card docs now:
After the changes:
