refactor: remove duplicate theme style warnings #31361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
andrewseguin
added
the
target: minor
andrewseguin
force-pushed
the
remove-warning
branch
from
adc0e00 to
fe85c4d
Compare
andrewseguin
force-pushed
the
remove-warning
branch
from
fe85c4d to
882c931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Sass warning about duplicate styles being emitted. This can happen if a theme file emits styles twice.
This was only really an issue before we used CSS variables, since the theme files emitted longer concrete CSS styles. Now, it's really not a big deal if extra tokens are emitted since its very minimal. Also, it's not clear users understood how to evade this warning, especially in an ergonomic way