Adaptive Templates Corner Rounding Example - e10 template different corner radii #465
Conversation
JackB-Ansys
commented
Jan 30, 2025
JackB-Ansys
commented
JackB-Ansys
requested review from
james-packer,
jgsdavies,
matthewAnsys and
ravi-ansys
as code owners
github-actions
bot
added
the
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
+ Coverage 88.01% 88.06% +0.04%
==========================================
Files 24 24
Lines 3689 3703 +14
==========================================
+ Hits 3247 3261 +14
Misses 442 442 🚀 New features to boost your workflow:
|
…corner_rounded_example_AdTemp
…corner_rounded_example_AdTemp
|
I think this example is ready to be merged now |
|
|
||
| from copy import deepcopy | ||
|
|
||
| # sphinx_gallery_thumbnail_path = 'images/adaptive_templates/IPM_rounded.png' |
There was a problem hiding this comment.
I don't think the sphinx image path should be in the middle of the imports, can it be moved above or below please?
| # :width: 600pt | ||
|
|
||
|
|
||
| def corners_to_round(region_to_round, other_regions): |
There was a problem hiding this comment.
Could you add a comment about what this does. I think it's finding the points in region_to_round that aren't in other_regions, but it would be useful to explain this.
| # Keep pocket properties but replace pocket entities with magnet entities | ||
| if type(magnets) == list: | ||
| magnets_utd = deepcopy(magnets[0]) | ||
| magnets_utd.unite(magnets[1]) |
There was a problem hiding this comment.
I think this is assuming that if magnets is a list, it contains exactly 2 items. Is this always true? A comment to explain the logic here might help
