Skip to content

Clickhouse IT RM JDBC fix + ClickHouseRowsCheck #34407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 22, 2025
Merged

Clickhouse IT RM JDBC fix + ClickHouseRowsCheck #34407

merged 13 commits into from
Apr 22, 2025

Conversation

BentsiLeviav
Copy link
Contributor

In this PR, the following is introduced:

  • A fix to the get JDBC function
  • Implement ClickHouseRowsCheck

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions GitHub Actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions GitHub Actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Reminder, please take a look at this pr: @damondouglas

@BentsiLeviav BentsiLeviav mentioned this pull request Apr 3, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions GitHub Actions
Copy link
Contributor

Reminder, please take a look at this pr: @damondouglas

@BentsiLeviav
Copy link
Contributor Author

Hi @damondouglas
When you have time, could you please review this PR?

Thanks!!

@github-actions GitHub Actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@liferoad liferoad merged commit 8dd0780 into apache:master Apr 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzitnik mzitnik mzitnik approved these changes

@liferoad liferoad liferoad approved these changes

Assignees
No one assigned
Labels
Next Action: Reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BentsiLeviav @mzitnik @liferoad