[BigQueryIO] support MicrosInstant type (for xlang) #34707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr just adding some missing logic to support converting BQ timestamp type --> Java logical timestamp type --> Python timestamp type
We have some existing Schema translation between Python and Java SDKs for Timestamps. A Python Timestamp maps to a Java MicrosInstant (aka SqlTypes.TIMESTAMP)
Writing timestamps to BQ Storage Write API with the Python SDK works fine, but when a row fails and we try converting the BQ type back to a MicrosInstant, we get the following error:
We're just missing some logic that accounts for when we want to convert a BQ timestamp to a MicrosInstant. I believe this was neglected because MicrosInstant isn't meant to be used as a Java native type.