Skip to content

Update RunInference type hints to PEP 585 standards #34719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

jrmccluskey
Copy link
Contributor

Updates RunInference model handlers to PEP 585 standards, migrating away from the typing module as appropriate.

Part of #32969


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@jrmccluskey
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Collaborator

@shunping shunping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test failure seems unrelated.

Looks like the type hints in Anomaly Detection needs to be updated to follow PEP 585 as well.

@jrmccluskey
Copy link
Contributor Author

LGTM. The test failure seems unrelated.

Looks like the type hints in Anomaly Detection needs to be updated to follow PEP 585 as well.

Yeah the failures are the known issue with the gcsio retry test.

Updating hints is usually pretty straightforward, the full migration list is at https://peps.python.org/pep-0585/ but for beam it's usually moving to the built-in types (tuple, list, dict, set, frozenset) and then swapping the abstract containers from typing to the collections.abc equivalents. Under the hood the typing versions are just aliased versions of the collections versions now anyway

@jrmccluskey jrmccluskey merged commit e69a7ba into apache:master Apr 24, 2025
83 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants