Skip to content

Deep copy PipelineOptions and keep the input intact. #34723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

shunping
Copy link
Collaborator

@shunping shunping commented Apr 24, 2025

Users typically expect the pipeline options they provide to remain unchanged after running a pipeline. Therefore, we make a deep copy of the provided options to prevent any accidental modification or "overwrite" during pipeline preparation and execution.

fixes #34722

@shunping shunping self-assigned this Apr 24, 2025
@shunping shunping force-pushed the deep-copy-pipeline-options branch 2 times, most recently from 1612410 to bec5b9b Compare April 24, 2025 03:36
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@shunping shunping force-pushed the deep-copy-pipeline-options branch from 488b5c4 to f89ffd1 Compare April 24, 2025 18:12
@shunping shunping requested a review from kennknowles April 24, 2025 18:22
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping shunping force-pushed the deep-copy-pipeline-options branch from f89ffd1 to bd46c97 Compare April 24, 2025 22:58
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.48%. Comparing base (8cd0a29) to head (bd46c97).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master   #34723    +/-   ##
==========================================
  Coverage     56.48%   56.48%            
  Complexity     3289     3289            
==========================================
  Files          1178     1179     +1     
  Lines        180978   181164   +186     
  Branches       3399     3399            
==========================================
+ Hits         102220   102327   +107     
- Misses        75499    75578    +79     
  Partials       3259     3259            
Flag Coverage Δ
python 81.25% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrmccluskey jrmccluskey merged commit a71dd28 into apache:master Apr 25, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pipeline Options changed after pipeline execution
3 participants