Skip to content

[Improve](explode) explode function support multi param #50310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 23, 2025
Merged

[Improve](explode) explode function support multi param #50310

merged 12 commits into from
Apr 23, 2025

Conversation

taptao
Copy link
Contributor

@taptao taptao commented Apr 22, 2025

What problem does this PR solve?

backport:#48537
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@taptao taptao requested a review from yiguolei as a code owner April 22, 2025 14:26
@Thearas
Copy link
Contributor

Thearas commented Apr 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@taptao
Copy link
Contributor Author

taptao commented Apr 22, 2025

run buildall

@taptao
Copy link
Contributor Author

taptao commented Apr 22, 2025

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 65.33% (130/199) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.82% (10263/26436)
Line Coverage 29.88% (85232/285263)
Region Coverage 28.53% (43934/153966)
Branch Coverage 25.25% (22457/88926)

@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 65.33% (130/199) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

yiguolei
yiguolei reviewed Apr 23, 2025
View reviewed changes
be/src/vec/exprs/table_function/table_function_factory.cpp
@@ -61,14 +63,21 @@ const std::unordered_map<std::string, std::function<std::unique_ptr<TableFunctio
{"explode_map", TableFunctionCreator<VExplodeMapTableFunction> {}},
{"explode_json_object", TableFunctionCreator<VExplodeJsonObjectTableFunction> {}},
{"posexplode", TableFunctionCreator<VPosExplodeTableFunction> {}},
{"explode", TableFunctionCreator<VExplodeTableFunction> {}}};
{"explode", TableFunctionCreator<VExplodeV2TableFunction> {}},
{"explode_old", TableFunctionCreator<VExplodeTableFunction> {}}};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要用这种old 类似的名字，长期来看，万一后面我们再变动，叫old 没法枚举。
我们叫v1，v2，这样还可以有v3，v4.。。
另外，每个函数后面都得加注释，写明变更的原因，比如是为了支持什么兼容？新功能？之类的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前背景， explode_old 函数保留只是为了升级场景，当升级完成后，这个函数可以被移除，所以没有考虑多版本的情况。以及这个函数名称和函数注册地方相关，暂时没做多版本的注册控制，只补充了新版和旧版的控制。
我可以对 VExplodeV2TableFunction 补充下注释信息，写明变更的原因和变更内容。

@taptao
Copy link
Contributor Author

taptao commented Apr 23, 2025

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 65.33% (130/199) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.83% (10267/26438)
Line Coverage 29.89% (85269/285271)
Region Coverage 28.55% (43951/153968)
Branch Coverage 25.27% (22468/88926)

@taptao
Copy link
Contributor Author

taptao commented Apr 23, 2025

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 65.33% (130/199) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.83% (10266/26438)
Line Coverage 29.88% (85251/285288)
Region Coverage 28.54% (43940/153980)
Branch Coverage 25.26% (22463/88938)

@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 66.01% (134/203) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 66.01% (134/203) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage
Line Coverage
Region Coverage
Branch Coverage

@yiguolei yiguolei merged commit cf72fa8 into apache:branch-2.1 Apr 23, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taptao @Thearas @hello-stephen @doris-robot @yiguolei