Skip to content

[fix](array-index) Fix types that do not support indexing also in array nesting should also not be supported. #50162 #50315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: branch-3.0
Choose a base branch
from

Conversation

amorynan
Copy link
Contributor

@amorynan amorynan commented Apr 23, 2025

What problem does this PR solve?

backpoint: #50162
and patch #50382
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@amorynan amorynan requested a review from dataroaring as a code owner April 23, 2025 02:42
@Thearas
Copy link
Contributor

Thearas commented Apr 23, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan
Copy link
Contributor Author

run buildall

@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40094 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a4dfe9789ea08c4079fed52505e6f6611cac68ce, data reload: false

------ Round 1 ----------------------------------
q1	17574	6781	6592	6592
q2	2077	169	185	169
q3	10654	1055	1138	1055
q4	10570	753	782	753
q5	7724	2882	2835	2835
q6	217	134	131	131
q7	981	630	610	610
q8	9496	1908	2000	1908
q9	6525	6371	6411	6371
q10	7058	2313	2365	2313
q11	471	263	260	260
q12	399	214	213	213
q13	17823	3106	3062	3062
q14	236	225	224	224
q15	494	456	465	456
q16	700	598	582	582
q17	978	597	558	558
q18	7267	6584	6594	6584
q19	1396	1018	1032	1018
q20	472	203	211	203
q21	3982	3266	3219	3219
q22	1084	978	986	978
Total cold run time: 108178 ms
Total hot run time: 40094 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6594	6567	6552	6552
q2	337	236	230	230
q3	2889	2761	2895	2761
q4	2025	1810	1763	1763
q5	5715	5761	5723	5723
q6	211	127	126	126
q7	2210	1824	1788	1788
q8	3318	3547	3532	3532
q9	8972	8759	8845	8759
q10	3541	3512	3487	3487
q11	585	498	496	496
q12	781	601	600	600
q13	10154	3154	3185	3154
q14	291	276	258	258
q15	498	457	457	457
q16	711	657	646	646
q17	1841	1618	1572	1572
q18	8158	7893	7761	7761
q19	1687	1537	1510	1510
q20	2012	1807	1799	1799
q21	5406	5312	5271	5271
q22	1120	1076	1024	1024
Total cold run time: 69056 ms
Total hot run time: 59269 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197497 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a4dfe9789ea08c4079fed52505e6f6611cac68ce, data reload: false

query1	1265	908	882	882
query2	6349	1972	1922	1922
query3	10795	4276	4182	4182
query4	61754	28740	23864	23864
query5	5306	459	443	443
query6	396	167	177	167
query7	5497	319	309	309
query8	310	222	225	222
query9	8698	2637	2604	2604
query10	468	276	260	260
query11	17806	15240	16146	15240
query12	156	111	104	104
query13	1461	441	448	441
query14	10475	7016	6647	6647
query15	208	176	178	176
query16	7171	483	491	483
query17	1158	575	567	567
query18	1987	321	313	313
query19	212	156	156	156
query20	116	108	107	107
query21	204	111	109	109
query22	4625	4486	4593	4486
query23	34600	34179	34272	34179
query24	6224	2924	2947	2924
query25	546	431	412	412
query26	690	171	168	168
query27	2102	363	374	363
query28	4262	2484	2471	2471
query29	722	464	432	432
query30	252	162	172	162
query31	983	823	830	823
query32	68	56	60	56
query33	398	281	293	281
query34	929	488	528	488
query35	868	718	718	718
query36	1098	977	959	959
query37	112	64	69	64
query38	4074	4001	3942	3942
query39	1502	1440	1497	1440
query40	213	98	98	98
query41	49	46	47	46
query42	115	95	98	95
query43	517	485	485	485
query44	1148	820	818	818
query45	187	168	172	168
query46	1177	733	734	733
query47	2045	1888	1953	1888
query48	486	382	391	382
query49	727	398	388	388
query50	855	426	423	423
query51	7400	7276	7242	7242
query52	103	90	90	90
query53	267	180	179	179
query54	571	478	461	461
query55	79	77	75	75
query56	262	238	246	238
query57	1280	1146	1195	1146
query58	215	221	224	221
query59	3318	3043	3013	3013
query60	290	267	252	252
query61	107	119	108	108
query62	750	693	659	659
query63	216	187	184	184
query64	1375	674	644	644
query65	3262	3190	3224	3190
query66	703	322	299	299
query67	15883	15660	15685	15660
query68	4305	569	557	557
query69	442	266	258	258
query70	1162	1107	1146	1107
query71	337	262	252	252
query72	6358	4017	4117	4017
query73	758	352	351	351
query74	10311	9106	9326	9106
query75	3321	2630	2672	2630
query76	1890	1089	1101	1089
query77	502	271	277	271
query78	10582	9691	9690	9690
query79	1150	591	590	590
query80	822	430	435	430
query81	511	240	242	240
query82	1305	88	86	86
query83	160	143	140	140
query84	287	86	81	81
query85	845	312	288	288
query86	330	311	302	302
query87	4431	4258	4228	4228
query88	3379	2396	2366	2366
query89	430	294	286	286
query90	1950	179	181	179
query91	184	144	149	144
query92	58	50	51	50
query93	1290	550	567	550
query94	734	305	291	291
query95	353	257	250	250
query96	610	276	289	276
query97	3317	3167	3165	3165
query98	206	205	201	201
query99	1827	1294	1275	1275
Total cold run time: 313594 ms
Total hot run time: 197497 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.94 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a4dfe9789ea08c4079fed52505e6f6611cac68ce, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.07
query4	1.63	0.10	0.11
query5	0.52	0.51	0.52
query6	1.14	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.51	0.50
query10	0.54	0.56	0.56
query11	0.15	0.10	0.10
query12	0.14	0.12	0.12
query13	0.60	0.60	0.59
query14	2.73	2.73	2.84
query15	0.91	0.82	0.81
query16	0.37	0.36	0.38
query17	1.07	1.04	0.98
query18	0.24	0.22	0.22
query19	1.98	1.80	2.03
query20	0.02	0.01	0.01
query21	15.36	0.58	0.57
query22	2.39	2.78	2.77
query23	16.99	0.86	0.79
query24	3.39	0.90	1.51
query25	0.19	0.16	0.12
query26	0.43	0.14	0.14
query27	0.04	0.04	0.04
query28	10.02	0.54	0.47
query29	12.58	3.20	3.21
query30	0.24	0.06	0.05
query31	2.86	0.38	0.38
query32	3.28	0.47	0.46
query33	3.00	3.04	3.04
query34	17.06	4.49	4.45
query35	4.53	4.52	4.48
query36	0.66	0.47	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.15	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 106.48 s
Total hot run time: 32.94 s

@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40088 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 469ee5b62c62bb5a708171784fca0e5a147ce1ad, data reload: false

------ Round 1 ----------------------------------
q1	17589	6824	6669	6669
q2	2053	185	191	185
q3	10519	1086	1189	1086
q4	10559	725	679	679
q5	7779	2921	2871	2871
q6	223	135	138	135
q7	986	623	599	599
q8	9366	1947	2021	1947
q9	6635	6410	6419	6410
q10	7025	2314	2284	2284
q11	475	268	269	268
q12	405	215	207	207
q13	17807	2985	3006	2985
q14	239	207	219	207
q15	501	470	483	470
q16	661	578	591	578
q17	991	541	539	539
q18	7403	6725	6575	6575
q19	1407	1105	1078	1078
q20	484	206	205	205
q21	4313	3113	3245	3113
q22	1065	998	1019	998
Total cold run time: 108485 ms
Total hot run time: 40088 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6588	6590	6532	6532
q2	331	232	228	228
q3	2873	2792	2921	2792
q4	2057	1778	1748	1748
q5	5795	5711	5757	5711
q6	207	129	132	129
q7	2221	1771	1801	1771
q8	3370	3613	3534	3534
q9	8955	8757	8917	8757
q10	3553	3523	3501	3501
q11	576	495	501	495
q12	796	608	617	608
q13	9237	3150	3146	3146
q14	299	278	278	278
q15	501	472	469	469
q16	683	652	633	633
q17	1842	1628	1613	1613
q18	8252	7820	7700	7700
q19	1694	1572	1705	1572
q20	2056	1842	1827	1827
q21	5615	5357	5348	5348
q22	1115	1067	1033	1033
Total cold run time: 68616 ms
Total hot run time: 59425 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196959 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 469ee5b62c62bb5a708171784fca0e5a147ce1ad, data reload: false

query1	1305	902	894	894
query2	6327	2045	1993	1993
query3	10851	4241	4377	4241
query4	61319	29127	23715	23715
query5	5347	452	455	452
query6	400	186	172	172
query7	5431	313	304	304
query8	307	232	218	218
query9	8309	2627	2625	2625
query10	460	272	268	268
query11	17791	15245	15703	15245
query12	159	102	100	100
query13	1414	444	436	436
query14	9830	6896	7495	6896
query15	202	174	178	174
query16	7228	496	474	474
query17	1157	576	569	569
query18	1819	331	308	308
query19	215	163	159	159
query20	117	112	110	110
query21	211	104	103	103
query22	4681	4506	4770	4506
query23	34774	34506	33755	33755
query24	6217	2992	3002	2992
query25	565	437	433	433
query26	666	176	178	176
query27	1962	380	373	373
query28	4496	2490	2467	2467
query29	700	500	437	437
query30	256	165	162	162
query31	1003	831	845	831
query32	66	56	55	55
query33	418	313	308	308
query34	914	502	530	502
query35	863	751	727	727
query36	1084	932	944	932
query37	117	67	69	67
query38	4029	3917	3974	3917
query39	1554	1483	1485	1483
query40	203	108	99	99
query41	49	48	48	48
query42	117	109	100	100
query43	522	501	505	501
query44	1160	860	834	834
query45	193	163	167	163
query46	1158	725	729	725
query47	2046	1917	1940	1917
query48	487	383	411	383
query49	745	388	388	388
query50	837	429	443	429
query51	7512	7125	7295	7125
query52	110	91	98	91
query53	283	186	178	178
query54	563	466	459	459
query55	81	76	82	76
query56	274	235	247	235
query57	1273	1177	1180	1177
query58	227	212	214	212
query59	3279	3162	3011	3011
query60	290	263	252	252
query61	116	112	136	112
query62	777	667	659	659
query63	216	181	185	181
query64	2041	680	644	644
query65	3270	3216	3188	3188
query66	734	328	292	292
query67	15947	15715	15497	15497
query68	4346	583	576	576
query69	440	257	260	257
query70	1138	1057	1126	1057
query71	327	241	247	241
query72	6278	3991	3986	3986
query73	753	351	354	351
query74	10212	9117	8928	8928
query75	3371	2612	2668	2612
query76	1973	1067	1047	1047
query77	488	288	268	268
query78	10627	9613	9644	9613
query79	1719	602	594	594
query80	1113	416	446	416
query81	533	237	234	234
query82	1248	87	87	87
query83	273	144	144	144
query84	283	84	75	75
query85	906	332	292	292
query86	340	293	297	293
query87	4386	4259	4266	4259
query88	3851	2399	2366	2366
query89	416	298	290	290
query90	1987	183	185	183
query91	183	151	151	151
query92	69	51	49	49
query93	2029	555	560	555
query94	760	301	310	301
query95	355	262	255	255
query96	607	287	283	283
query97	3262	3159	3174	3159
query98	220	205	201	201
query99	1608	1332	1281	1281
Total cold run time: 315175 ms
Total hot run time: 196959 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 469ee5b62c62bb5a708171784fca0e5a147ce1ad, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.10	0.10
query5	0.52	0.52	0.52
query6	1.14	0.73	0.74
query7	0.02	0.02	0.02
query8	0.06	0.04	0.03
query9	0.57	0.51	0.50
query10	0.55	0.54	0.58
query11	0.14	0.10	0.11
query12	0.13	0.11	0.12
query13	0.60	0.60	0.58
query14	2.86	2.75	2.86
query15	0.90	0.84	0.82
query16	0.39	0.40	0.39
query17	1.06	1.04	1.03
query18	0.24	0.22	0.20
query19	1.88	1.83	1.98
query20	0.01	0.02	0.01
query21	15.36	0.59	0.58
query22	2.41	2.63	2.45
query23	17.29	0.94	0.86
query24	3.86	1.46	2.01
query25	0.29	0.10	0.05
query26	0.57	0.14	0.13
query27	0.05	0.04	0.05
query28	8.46	0.55	0.48
query29	12.64	3.25	3.24
query30	0.24	0.06	0.06
query31	2.88	0.37	0.38
query32	3.26	0.46	0.45
query33	2.95	3.04	3.05
query34	16.99	4.51	4.49
query35	4.54	4.51	4.49
query36	0.67	0.48	0.47
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.03	0.03
query40	0.16	0.12	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.97 s
Total hot run time: 33.36 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants