Skip to content

branch-3.0: [fix](cloud-mow)Schema change fail should release delete bitmap lock #49889 #50335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

branch-3.0: [fix](cloud-mow)Schema change fail should release delete bitmap lock #49889 #50335

merged 1 commit into from
Apr 24, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #49889

@hust-hhb
[fix](cloud-mow)Schema change fail should release delete bitmap lock (#…
dc2969c 
…49889)

When sc fail, it will abort sc job by fe, however it forget to release
delete bitmap lock, which will block data input.
@github-actions github-actions bot requested a review from dataroaring as a code owner April 23, 2025 09:08
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 23, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 83.00% (1084/1306)
Line Coverage: 65.92% (17926/27194)
Region Coverage: 65.44% (8838/13505)
Branch Coverage: 55.35% (4769/8616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dc2969cbab3121da8d6b5ae73b158d6468bfa497_dc2969cbab3121da8d6b5ae73b158d6468bfa497_cloud/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40481 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dc2969cbab3121da8d6b5ae73b158d6468bfa497, data reload: false

------ Round 1 ----------------------------------
q1	17628	6774	6604	6604
q2	2065	173	174	173
q3	10832	1082	1154	1082
q4	10581	787	752	752
q5	7753	2862	2812	2812
q6	227	134	135	134
q7	969	631	603	603
q8	9353	1962	2018	1962
q9	6598	6427	6406	6406
q10	7025	2284	2291	2284
q11	475	260	263	260
q12	408	216	214	214
q13	17786	3017	2990	2990
q14	243	215	211	211
q15	498	451	476	451
q16	678	592	584	584
q17	994	523	597	523
q18	7342	6899	6875	6875
q19	1405	1058	968	968
q20	487	217	227	217
q21	4123	3369	3426	3369
q22	1125	1007	1040	1007
Total cold run time: 108595 ms
Total hot run time: 40481 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6734	6637	6621	6621
q2	336	238	233	233
q3	2949	2839	2915	2839
q4	2051	1918	1832	1832
q5	5785	5746	5739	5739
q6	215	129	132	129
q7	2242	1813	1799	1799
q8	3371	3502	3481	3481
q9	8906	8888	8910	8888
q10	3574	3494	3530	3494
q11	595	492	501	492
q12	817	585	598	585
q13	10143	3192	3198	3192
q14	306	261	260	260
q15	501	458	470	458
q16	710	644	645	644
q17	1833	1610	1609	1609
q18	8193	7904	7767	7767
q19	1724	1610	1505	1505
q20	2028	1776	1813	1776
q21	5415	5323	5316	5316
q22	1172	1098	1031	1031
Total cold run time: 69600 ms
Total hot run time: 59690 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/14) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.21% (10555/26248)
Line Coverage 30.98% (89292/288222)
Region Coverage 30.12% (46068/152973)
Branch Coverage 26.61% (23543/88466)

@doris-robot
Copy link

TPC-DS: Total hot run time: 196918 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dc2969cbab3121da8d6b5ae73b158d6468bfa497, data reload: false

query1	1259	913	913	913
query2	6221	1984	1973	1973
query3	10898	4457	4206	4206
query4	62042	29515	23487	23487
query5	5216	456	459	456
query6	395	180	173	173
query7	5464	310	309	309
query8	297	255	224	224
query9	8166	2645	2630	2630
query10	457	256	262	256
query11	17953	15096	15825	15096
query12	165	104	111	104
query13	1430	468	457	457
query14	10730	7121	6932	6932
query15	216	184	182	182
query16	7118	499	530	499
query17	1222	586	610	586
query18	1864	331	315	315
query19	216	160	152	152
query20	116	118	114	114
query21	209	110	107	107
query22	4730	4523	4582	4523
query23	33958	34195	33858	33858
query24	6198	3007	2930	2930
query25	505	396	397	396
query26	652	178	168	168
query27	1936	352	365	352
query28	4490	2457	2425	2425
query29	699	445	440	440
query30	242	167	167	167
query31	994	805	811	805
query32	67	52	58	52
query33	430	292	288	288
query34	930	507	510	507
query35	841	743	742	742
query36	1064	980	986	980
query37	121	64	65	64
query38	4055	4034	3954	3954
query39	1526	1486	1470	1470
query40	206	96	97	96
query41	50	46	50	46
query42	109	97	99	97
query43	525	471	493	471
query44	1192	851	833	833
query45	182	169	179	169
query46	1163	738	739	738
query47	2052	1984	1965	1965
query48	490	409	400	400
query49	739	389	385	385
query50	869	441	437	437
query51	7278	7102	7250	7102
query52	102	93	92	92
query53	263	184	185	184
query54	561	464	478	464
query55	78	77	74	74
query56	264	231	253	231
query57	1270	1141	1162	1141
query58	226	214	224	214
query59	3240	3109	3068	3068
query60	285	276	262	262
query61	113	106	105	105
query62	803	677	708	677
query63	221	192	182	182
query64	1381	666	669	666
query65	3276	3188	3197	3188
query66	690	301	307	301
query67	15841	15538	15537	15537
query68	4179	587	568	568
query69	418	265	266	265
query70	1201	1120	1088	1088
query71	339	263	266	263
query72	6360	3968	4265	3968
query73	752	348	356	348
query74	10502	9005	8921	8921
query75	3389	2661	2677	2661
query76	1837	1109	1039	1039
query77	501	264	269	264
query78	10493	9629	9552	9552
query79	1546	600	591	591
query80	888	422	438	422
query81	528	247	237	237
query82	1270	95	91	91
query83	253	152	147	147
query84	288	88	82	82
query85	960	368	355	355
query86	333	303	300	300
query87	4401	4253	4382	4253
query88	3771	2465	2365	2365
query89	411	302	301	301
query90	1974	189	190	189
query91	178	145	147	145
query92	61	46	49	46
query93	1852	567	571	567
query94	725	294	298	294
query95	368	280	261	261
query96	613	283	283	283
query97	3304	3161	3138	3138
query98	213	199	195	195
query99	1660	1320	1302	1302
Total cold run time: 314129 ms
Total hot run time: 196918 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.66 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dc2969cbab3121da8d6b5ae73b158d6468bfa497, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.04	0.03
query3	0.22	0.07	0.06
query4	1.63	0.10	0.10
query5	0.51	0.52	0.50
query6	1.14	0.72	0.75
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.49	0.48
query10	0.56	0.55	0.54
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.73	2.74	2.71
query15	0.90	0.86	0.82
query16	0.39	0.39	0.39
query17	1.05	1.05	1.00
query18	0.26	0.21	0.23
query19	1.95	1.89	1.96
query20	0.01	0.01	0.01
query21	15.35	0.58	0.58
query22	2.55	1.92	1.96
query23	17.26	1.24	0.80
query24	2.93	1.47	1.28
query25	0.28	0.27	0.08
query26	0.39	0.14	0.14
query27	0.03	0.04	0.04
query28	9.86	0.47	0.50
query29	12.58	3.41	3.36
query30	0.25	0.06	0.05
query31	2.87	0.39	0.38
query32	3.25	0.46	0.47
query33	3.03	3.03	3.00
query34	17.14	4.51	4.49
query35	4.55	4.50	4.53
query36	0.68	0.48	0.48
query37	0.09	0.07	0.06
query38	0.04	0.03	0.04
query39	0.03	0.03	0.02
query40	0.16	0.12	0.13
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.43 s
Total hot run time: 32.66 s

dataroaring
dataroaring approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 24, 2025
@github-actions GitHub Actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 12572b0 into branch-3.0 Apr 24, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49889-branch-3.0 branch April 24, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hello-stephen @doris-robot @dataroaring @hust-hhb