fix(handleIcon): unexpected aspect ratio of handleIcon #20895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
The issue #18444 mentioned that when the handleIcon is customized as an image dataUrl, it becomes stretched when
setOption
orresize
is called again. This issue was closed by author because the phenomenon did not occur when the custom handleIcon had equal width and height. However, I believe it's important to support images with an aspect ratio other than 1:1, so I made some modifications to handle that.Fixed issues
Details
Before: What was the problem?
This is a link to minimal reproduction:
https://stackblitz.com/edit/stackblitz-starters-whzflubq?file=index.html
In this example, the handleIcon is customized using a dataURL, and its aspect ratio is not 1:1.
After: How does it behave after the fixing?
In

/src/graphic.ts
, anonload
callback is passed when creating aZRImage
, which calibrates the image's aspect ratio and is triggered only during the first rendering of the chart. Therefore, I appended an additional calibration step after creatingZRImage
. I used a newImage
object to load the dataURL and obtain the accurate dimensions of the image. Normally, the image dimensions are obtained via theonload
callback, but this will cause the rendered image size to fluctuate:I discovered that if the dataURL has been loaded before, the image dimensions can often be retrieved synchronously from cache. In such cases, I perform the aspect ratio calibration synchronously. However, since I'm not certain all browsers support this caching behavior reliably, I repeated the calibration within the onload callback to ensure that the obtained dimensions are ultimately accurate.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information