[HUDI-9206] Support reading inflight instants with HoodieLogRecordReader #13010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
reviewed
Mar 21, 2025
|
@lokeshj1703 , the context is not clear. Can you explain more on "since RLI reads the log records and finds deleted keys."? |
nsivabalan
reviewed
Mar 25, 2025
hudi-common/src/test/java/org/apache/hudi/common/table/read/TestHoodieFileGroupReaderBase.java
Outdated
Show resolved
Hide resolved
...park/src/test/scala/org/apache/hudi/common/table/read/TestHoodieFileGroupReaderOnSpark.scala
Outdated
Show resolved
Hide resolved
yihua
previously requested changes
Mar 26, 2025
| commitToTable(dataGen.generateInserts("001", 100), INSERT.value, writeConfigs) | ||
| validateOutputFromFileGroupReader(getStorageConf, getBasePath, dataGen.getPartitionPaths, true, 0, recordMergeMode) | ||
|
|
||
| commitToTable(dataGen.generateUniqueUpdates("003", 100), UPSERT.value, writeConfigs) |
There was a problem hiding this comment.
Could you prepare the table instead of transactions? Also, could this validation be added to existing tests, i.e., adding a new step in existing tests to remove completed detlacommit from the timeline so that data files become inflight and should not be read? So that we don't need this new test and we can have more coverage with different permutations.
There was a problem hiding this comment.
I have added a UT now. This test has been removed.
yihua
reviewed
Mar 26, 2025
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java
Show resolved
Hide resolved
nsivabalan
approved these changes
Mar 27, 2025
danny0405
reviewed
Mar 27, 2025
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java
Show resolved
Hide resolved
danny0405
requested changes
Mar 27, 2025
danny0405
reviewed
Mar 28, 2025
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java
Show resolved
Hide resolved
nsivabalan
approved these changes
Apr 2, 2025
|
@danny0405 : are you good w/ the patch. If yes, can we go ahead and land the patch. |
|
|
|
I'm fine with the change. |
danny0405
approved these changes
Apr 2, 2025
nsivabalan
dismissed
yihua’s stale review
We are going ahead for now to get this into 1.0.2. Feel free to review this async. author can address it in a follow up patch.
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 8, 2025
…der (apache#13010) (cherry picked from commit 1f52b4e)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 9, 2025
…der (apache#13010) (cherry picked from commit 1f52b4e)
4 tasks
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 11, 2025
…der (apache#13010) (cherry picked from commit 1f52b4e)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 15, 2025
…der (apache#13010) (cherry picked from commit 1f52b4e)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 16, 2025
…der (apache#13010) (cherry picked from commit 1f52b4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
The PR adds capability to read inflight instants with HoodieLogRecordReader by adding
allowInflightInstantsflag. The capability is required for updating RLI since RLI reads the log records and finds deleted keys.While replacing
HoodieMergedLogRecordScannerwith new reader class, we need to use the allowInflightInstants flag.Impact
NA
Risk level (write none, low medium or high below)
low
Documentation Update
NA
Contributor's checklist