Skip to content

feat(datahub-sync): adds DataPlatformInstance aspect #13133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Apr 11, 2025

Change Logs

This update introduces the ability to set DataPlatformInstance via configuration.

Before this PR:

  • DataPlatformInstance was not emitted for either Dataset or Container entities.
  • It was automatically injected by the DataHub backend, only for Dataset, and included only the platform field.

With this PR:

  • If no platform instance is configured:

    • DataPlatformInstance is consistently emitted for both Dataset and Container entities, including only the platform field.
  • If a platform instance is configured:

    • DataPlatformInstance is consistently emitted for both Dataset and Container entities, including both the platform and instance fields.
    • The platform instance is included in the browse paths.
    • The platform instance is also included in the identity (URN) for both Dataset and Container.

Consistent and correct management of DataPlatformInstance aspect is relevant for the platform instance filtering in the DataHub UI as well as the browsing experience.

Impact

Low

Risk level (write none, low medium or high below)

None

Documentation Update

  • The new optional config feature needs to be documented

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Apr 11, 2025
@sgomezvillamor sgomezvillamor marked this pull request as ready for review April 11, 2025 07:30
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M PR with lines of changes in (100, 300]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants