[HUDI-9321] Fix unnecessary hoodie config conversion for ConfigUtils.getPayloadClass #13167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, ConfigUtils.getPayloadClass will be called at record level during log scanning of regular read and compaction.
|
codope
approved these changes
Apr 18, 2025
github-project-automation
bot
moved this from 🆕 New
to 🛬 Near landing
in Hudi PR Support
github-project-automation
bot
moved this from 🛬 Near landing
to ✅ Done
in Hudi PR Support
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 18, 2025
…getPayloadClass (apache#13167) The construction of HoodieConfig is very costly, this would impact the regular read and also compaction. (cherry picked from commit d6c1272)
yihua
reviewed
Apr 18, 2025
| public static String getPayloadClass(Properties properties) { | ||
| return HoodieRecordPayload.getPayloadClassName(new HoodieConfig(properties)); | ||
| public static String getPayloadClass(Properties props) { | ||
| return HoodieRecordPayload.getPayloadClassName(props); |
There was a problem hiding this comment.
Good catch. Have you checked if there is other place using new HoodieConfig, in which all of them should be fixed if unnecessary?
There was a problem hiding this comment.
We do have many other new HoodieConfig invocations, but not at per-row level. Do we need to fix them for 1.0.2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
The construction of HoodieConfig is very costly, this would impact the regular read and also compaction.
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist