[HUDI-8680] Update doc description for metadata index partition enable #13214
Conversation
|
Actually, let me reuse the JIRA of pr https://github.com/apache/hudi/pull/12707 |
voonhous
changed the title
voonhous
force-pushed
the
fix-redudant-partition-stats-config-discrepancy
branch
from
05353ce to
6083ec0
Compare
| @@ -381,9 +381,10 @@ public final class HoodieMetadataConfig extends HoodieConfig { | |||
|
|
|||
| public static final ConfigProperty<Boolean> ENABLE_METADATA_INDEX_PARTITION_STATS = ConfigProperty | |||
| .key(METADATA_PREFIX + ".index.partition.stats.enable") | |||
| .defaultValue(false) | |||
| .defaultValue(true) | |||
There was a problem hiding this comment.
we do this at per engine level. thats why we did not flip this value.
if you check HoodieMetadataConfig,
we have getDefaultColStatsEnable() which will choose the right value for col stats for different engines.
and the default value for partitions stats enable goes along w/ the derived value for col stats.
if col stats is enabled, PSI will also be enabled. if not, it will not.
We just need to update our release docs to call this out.
There was a problem hiding this comment.
I have updated the description ,PTAL
No other issues aside from doc discrepancy. Let me change the doc description for this to call the behaviour out then and keep the default value as false. |
voonhous
changed the title
voonhous
force-pushed
the
fix-redudant-partition-stats-config-discrepancy
branch
from
faba473 to
53eb921
Compare
voonhous
force-pushed
the
fix-redudant-partition-stats-config-discrepancy
branch
from
53eb921 to
eac3675
Compare
github-actions
bot
added
size:S
apache#13214) (cherry picked from commit abae99c)
Change Logs
ENABLE_METADATA_INDEX_PARTITION_STATSis enabled by default, a change that was introduce in the PR below that sets its default value to the value ofENABLE_METADATA_INDEX_COLUMN_STATShere:https://github.com/apache/hudi/pull/12707/files#diff-11e9ef6bd53ef1001b669a1dc68dde2aba9b33c9eb72cc1e4198750336d79772R893
However, the config value is false. This PR changes the config value to remove this discrepancy. Automated config docs will also be updated as a result to reduce confusion.
In this PR, we are updating the doc description to better reflect the default value of this config.
Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
Default value of
ENABLE_METADATA_INDEX_PARTITION_STATS/hoodie.metadata.index.partition.enablewill be changed in the config docs.Contributor's checklist