kie-issues#315: DMN Runner table view should display validation messages

[Kusuma04-dev]

closes apache/incubator-kie-issues#315 DMN Runner table view should display validation messages
Before fix:
we are displaying messages from decisionresults which is in response because of this few error messages are not getting displayed.
example: using round up function

After fix:
Now we are displaying the messages directly from response.
Example:

[jomarko]

Hi @Kusuma04-dev , thank you for the pull request. It will be very helpful for users to see these messages from backend 💪 .

However it seems we need to improve our code for transforming backend data into UI data. Once I created model with three decisions, the message was 'tripled' there. See the attached screenshot.

[Kusuma04-dev]

Hi @Kusuma04-dev , thank you for the pull request. It will be very helpful for users to see these messages from backend 💪 .

However it seems we need to improve our code for transforming backend data into UI data. Once I created model with three decisions, the message was 'tripled' there. See the attached screenshot.

Thanks Jozef for the review, I have missed to check this type of scenario. I have handled now.Please validate.

[ljmotta]

@Kusuma04-dev Thanks for addressing this bug! I've made some comments and questions inline regarding some of your choices.

[jomarko]

I will do my re-review after @ljmotta points are addressed, as he asked code changes that may change the final behavior.

[jomarko]

@Kusuma04-dev hi, I have a question, if DmnRunnerContextProvider could somehow reduce/aggregate messages information, to contain also row number. I mean, lest say we show validation messages for three rows, it would be nice to have some prefix in the message saying what row it is related to.

[Kusuma04-dev]

@Kusuma04-dev hi, I have a question, if DmnRunnerContextProvider could somehow reduce/aggregate messages information, to contain also row number. I mean, lest say we show validation messages for three rows, it would be nice to have some prefix in the message saying what row it is related to.

Hi @jomarko , In case of form , we are showing messages for that particular row only , so i feel it's understandable without row number also , WDYT?For example if we have 3 rows then if u select row 1 - only messages related to that row will display and if u go to row 2 then only messages related to row 2 will display. but in case of table ,might be needed to show row numbers as we are displaying all messages at a time.Let me check if it is possible.

[jomarko]

@Kusuma04-dev yes, I am sorry that I was not clear in my last comment. It is fine for me to keep formmode as it is. I spoke about table mode. In screenshot I used form mode but I wanted just highlight with the red text what information I speak about and what place in problems panel.

[jomarko]

The current content of the execution tab may be very overwhelmed. What @ljmotta mentioned, the aggregation using node name could help. It would bring some consistency into the app behavior that could help with a user experience.

What do you think about change form:

Current

to

Proposal

I have used model and data

• Untitled (2).dmn.txt
• Untitled.json

[ljmotta]

@jomarko I agree with Jozef. We need to keep the errors under the node name, or having multiple errors can be very dificult to track.