Skip to content

feature:[loom] replace the usages of synchronized with ReentrantLock at saga module #7174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: 2.x
Choose a base branch
from

Conversation

lightClouds917
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

replace the usages of synchronized with ReentrantLock at sage module

To use virtual threads in JDK 21, we need to remove the usage of synchronized to prevent the issue where "a virtual thread cannot be unmounted during blocking operations because it is pinned to its carrier."

There are two scenarios in which a virtual thread cannot be unmounted during blocking operations because it is pinned to its carrier:

When it executes code inside a synchronized block or method, or When it executes a native method or a foreign function.
Pinning does not make an application incorrect, but it might hinder its scalability. If a virtual thread performs a blocking operation such as I/O or BlockingQueue.take() while it is pinned, then its carrier and the underlying OS thread are blocked for the duration of the operation. Frequent pinning for long durations can harm the scalability of an application by capturing carriers.

The scheduler does not compensate for pinning by expanding its parallelism. Instead, avoid frequent and long-lived pinning by revising synchronized blocks or methods that run frequently and guard potentially long I/O operations to use java.util.concurrent.locks.ReentrantLock instead. There is no need to replace synchronized blocks and methods that are used infrequently (e.g., only performed at startup) or that guard in-memory operations. As always, strive to keep locking policies simple and clear.

You can refer to the following documents:

https://openjdk.org/jeps/444
https://openjdk.org/projects/loom/

Ⅱ. Does this pull request fix one issue?

fixed #7173

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.22%. Comparing base (757bf45) to head (ded3224).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7174      +/-   ##
============================================
+ Coverage     54.17%   54.22%   +0.04%     
- Complexity     7222     7261      +39     
============================================
  Files          1173     1176       +3     
  Lines         41796    41929     +133     
  Branches       4906     4918      +12     
============================================
+ Hits          22642    22734      +92     
- Misses        17013    17046      +33     
- Partials       2141     2149       +8     
Files with missing lines Coverage Δ
...io/seata/saga/proctrl/impl/ProcessContextImpl.java 12.12% <ø> (ø)
...ata/saga/proctrl/eventing/impl/DirectEventBus.java 82.14% <100.00%> (+0.66%) ⬆️
.../engine/invoker/impl/SpringBeanServiceInvoker.java 56.62% <100.00%> (-0.26%) ⬇️
...ga/statelang/domain/impl/ServiceTaskStateImpl.java 76.92% <100.00%> (+1.92%) ⬆️

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lightClouds917 lightClouds917 changed the title feature:[loom] replace the usages of synchronized with ReentrantLock at saga module [WIP]feature:[loom] replace the usages of synchronized with ReentrantLock at saga module Mar 5, 2025
@lightClouds917 lightClouds917 changed the title [WIP]feature:[loom] replace the usages of synchronized with ReentrantLock at saga module feature:[loom] replace the usages of synchronized with ReentrantLock at saga module Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: [loom] replace the usages of synchronized with ReentrantLock at sage module
2 participants