Skip to content

[MBUILDCACHE-123] remove duplicated codes by adding field cacheState to MojoParametersListener #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Apr 25, 2025

Even maven build cache extension is already enabled, MojoParametersListener#beforeMojoExecution needs to set projectExecutions only when source == Source.LIFECYCLE && !forkedExecution is true.
The most appropriate way to handle MBUILDCACHE-123 is adding field cacheState to MojoParametersListener and setting it's value by BuildCacheMojosExecutionStrategy.

@olamy

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a MBUILDCACHE JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MBUILDCACHE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@zrlw zrlw closed this Apr 25, 2025
@zrlw zrlw force-pushed the MBUILDCACHE-123-optimizedMojoParametersListener branch from 7fd9397 to dfc6cd9 Compare April 25, 2025 03:07
@zrlw zrlw reopened this Apr 25, 2025
@zrlw zrlw force-pushed the MBUILDCACHE-123-optimizedMojoParametersListener branch from 8b1b645 to abd7c64 Compare April 25, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant