PHOENIX-7442 Apply Spotless to reformat the entire codebase #2024
Conversation
|
Depends on #2023 |
NihalJain
force-pushed
the
PHOENIX-7442
branch
from
3dfb7ec to
3ae0e76
Compare
|
Requires #2023. Hence in DRAFT! |
|
TODO: Rebase before merge |
|
Thank you. |
Sure let me ping once again. |
| if (this.servers.containsKey(loc)) { | ||
| Long time = this.servers.get(loc); | ||
| if (EnvironmentEdgeManager.currentTimeMillis() - time > maxServerCacheTTL) return true; // cache | ||
| // was |
There was a problem hiding this comment.
manually fix this
| * "should" be, based on how it's used in the query. For example {@code foo < ? } would expect | ||
| * that the bind variable type matches or can be coerced to the type of foo. For (1), | ||
| * we check that the bind value has the correct type and for (2) we set the param | ||
| * Class that manages binding parameters and checking type matching. There are two main usages: 1) |
| } | ||
|
|
||
| /** | ||
| * Restrict view to be UPDATABLE if the view specification: 1. uses only the PK columns; 2. starts |
| return plan.getEstimateInfoTimestamp(); | ||
| } | ||
| @Override | ||
| public Long getEstimateInfoTimestamp() throws SQLException { |
There was a problem hiding this comment.
note to self: checkpoint
|
Thanks for this PR. I'm happy to spend some time reviewing it but I'm not sure where/how to start. I did look at 20 or so files and they look good. It's an honest question: Any suggestion how to really review this in a structured way? Or do you just look at a random subset of files and hope for the best. |
|
Since this is an automated reformat, a complete a review is hopeless.
Once we decided to reformat, and decided on the rules, review for the big bang reformat step is more of a formality. |
mvn spotless:applyto re-format the entire codebase