Skip to content

PHOENIX-7485: Add metrics for time taken during mutation plan creation and execution #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Extension of David's comments
  • Loading branch information
Sanjeet Malhotra committed Jan 29, 2025
commit f28a7682514db8f5d876a1ba213d0216162f5cc8
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,14 @@ static void assertSelectQueryTableMetrics(final String tableName, final boolean
* @param writeMutMetrics write mutation metrics object
* @param conn connection object. Note: this method must be called after connection close
* since that's where we populate table-level write metrics
*/
* @param expectedSystemCatalogMetric True if metrics for calls to SYSTEM.CATALOG table were captured
* and should be validated
* @param expectedMinMutationPlanCreationTime minimum expected time taken to create mutation plan
* @param expectedMinMutationPlanExecutionTime minimum expected time taken to execute mutation plan
* @param expectedMinExecuteMutationTime minimum expected time taken by executeMutation() call
*
* @throws SQLException
*/
private static void assertMutationTableMetrics(final boolean isUpsert, final String tableName,
final long expectedUpsertOrDeleteSuccessSqlCt,
final long expectedUpsertOrDeleteFailedSqlCt,
Expand Down