[SPARK-51869][SS] Create classification for user errors within UDFs for Scala TransformWithState #50667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericm-db
force-pushed
the
tws-user-error
branch
from
4f5005c to
5db1f4e
Compare
ericm-db
changed the title
HyukjinKwon
changed the title
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala
Show resolved
Hide resolved
ericm-db
force-pushed
the
tws-user-error
branch
from
46aa99c to
3f17b22
Compare
| } | ||
| ImplicitGroupingKeyTracker.removeImplicitKey() | ||
| } catch { | ||
| case sparkThrowable: SparkThrowable => |
There was a problem hiding this comment.
We need to check if the underlying exception has the error class already defined ?
There was a problem hiding this comment.
Is the existing code not sufficient? This is how ForeachBatch does it:
try {
batchWriter(ds, batchId)
} catch {
// The user code can throw any type of exception.
case NonFatal(e) if !e.isInstanceOf[SparkThrowable] =>
throw ForeachBatchUserFuncException(e)
}
There was a problem hiding this comment.
Can we also check for error class explicitly also - just to be safe ?
There was a problem hiding this comment.
Ohh sure yeah sorry - didn't realize that's what you meant. Yeah will add.
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala
Outdated
Show resolved
Hide resolved
anishshri-db
approved these changes
Apr 23, 2025
|
@HeartSaVioR can you PTAL when you get a chance? |
ericm-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds proper error handling to the handleInputRows method in TransformWithState
Why are the changes needed?
The changes improve error handling and reporting when users implement custom stateful processors. Without this change, when an error occurs within the handleInputRows function, users would receive a generic exception without clear indication that the error originated from their implementation. The new approach provides more descriptive error messages that pinpoint the source of the problem.
Does this PR introduce any user-facing change?
Yes, this PR introduces a user-facing change in the form of a new error message format for errors occurring within the StatefulProcessor's handleInputRows function. Users will now receive more descriptive error messages when their stateful processing logic fails.
How was this patch tested?
The patch was tested by adding two new test cases to TransformWithStateSuite:
"transformWithState - check that error within handleInputRows is classified" - tests that unclassified errors within the handleInputRows method are properly wrapped in a TransformWithStateUserFunctionException
"transformWithState - check that classified error is thrown from handleInputRows" - tests that already classified SparkThrowable exceptions are passed through correctly
Was this patch authored or co-authored using generative AI tooling?
No