fix(charts): show all x-axis date labels

[magickspell]

SUMMARY

Fix to display all x-axis date labels that are selected in the time grain.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

1. Create a BAR CHART
   
2. Add a timestamp field in QUERY -> X-AXIS
   
3. Select Month in TIME GRAIN
   Expect: All months should be displayed on the X-AXIS.

ADDITIONAL INFORMATION

• Has associated issue: Time Series Bar Chart is Showing only Alternate Months in the X axis despite having data #28053
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Unbounded splitNumber causing potential performance and readability issues ▹ view	🧠 Not in standard

Files scanned

​

File Path	Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[eschutho]

Thanks @magickspell, this looks great! What happens when you choose day or minute as the time grain? Does it still try to render every x-axis label, or will it then aggregate them?

[rusackas]

I wonder if we should have a checkbox control to enable this. I'm a little worried that even with larger timegrains, the labels might overlap when they're in the default (horizontal) layout.

[Vitor-Avila]

+1 on the checkbox (preferably disabled by default to preserve existing functionality)

[michael-s-molina]

splitNumber does not guarantee that all labels will be displayed.

Note that this number serves only as a recommendation, and the true segments may be adjusted based on readability.

You need to set interval, min, and max to achieve this functionality.

As splitNumber is a recommendation value, the calculated tick may not be the same as expected. In this case, interval should be used along with min and max to compulsively set tickings.

I also agree with the checkbox (disabled by default) approach.

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.