-
Notifications
You must be signed in to change notification settings - Fork 14.9k
fix(open-api): Add missing FormatQueryPayloadSchema and DashboardScreenshotPostSchema to open-api component schemas #33202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues.
Files scanned
File Path | Reviewed |
---|---|
superset/sqllab/api.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33202 +/- ##
===========================================
+ Coverage 0 83.25% +83.25%
===========================================
Files 0 553 +553
Lines 0 39923 +39923
===========================================
+ Hits 0 33237 +33237
- Misses 0 6686 +6686
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @dogfootruler-kr, I recommend installing and setting up pre-commit: https://superset.apache.org/docs/contributing/development/#git-hooks |
SUMMARY
FormatQueryPayloadSchema and DashboardScreenshotPostSchema were missing from the open-api spec component schemas which made the open-api invalid.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:


After:


TESTING INSTRUCTIONS
Check that FormatQueryPayloadSchema and DashboardScreenshotPostSchema now exists in open0api spec.
ADDITIONAL INFORMATION