fix(dashboard): filter numeric values correctly

[suraj-mandal]

SUMMARY

The following changes have been made:

Upon debugging the models.py file, it was observed that the integer values were not being converted to float, which led to a mismatch among values.

Screenshot of the correct changes after the fix

ADDITIONAL INFORMATION

• Fixes Incorrect filtering for numeric values with different decimal precision #33206
• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade are tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Redundant numeric casting fallback ▹ view	✅ Fix detected

Files scanned

​

File Path	Reviewed
superset/connectors/sqla/models.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[suraj-mandal]

I have made the fix

[suraj-mandal]

rusackas, I have created the PR that fixes the issue. Can you kindly check and let me know if the checks are successful, since I am not able to test them on my own. Locally I ran the pre-commit hook and it was successful.

[codecov]

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.72%. Comparing base (76d897e) to head (3e65daa).
Report is 1791 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/models/helpers.py	0.00%	6 Missing ⚠️
superset/connectors/sqla/models.py	16.66%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #33230      +/-   ##
==========================================
+ Coverage   60.48%   65.72%   +5.23%     
==========================================
  Files        1931      553    -1378     
  Lines       76236    39935   -36301     
  Branches     8568        0    -8568     
==========================================
- Hits        46114    26248   -19866     
+ Misses      28017    13687   -14330     
+ Partials     2105        0    -2105     

Flag	Coverage Δ
hive	48.27% <0.00%> (-0.88%)	⬇️
javascript	?
presto	52.75% <8.33%> (-1.06%)	⬇️
python	65.72% <8.33%> (+2.22%)	⬆️
unit	61.30% <0.00%> (+3.67%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[michael-s-molina]

Possible duplicate of #33222