refactor(ui): replace native HTML elements with Ant Design 5 components for consistent theming #33231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
…d FontAwesome icons with Ant Design v5 icons
…onents; adjust pagination colors
EnxDev
requested review from
sadpandajoe,
geido,
eschutho,
rusackas and
betodealmeida
as code owners
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/packages/superset-ui-chart-controls/src/components/Menu.tsx | ✅ |
| superset-frontend/packages/superset-ui-chart-controls/src/components/Dropdown.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/shared/components/Expandable.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/DataTable/components/GlobalFilter.tsx | ✅ |
| superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx | ✅ |
| superset-frontend/src/components/Pagination/Wrapper.tsx | ✅ |
| superset-frontend/packages/superset-ui-chart-controls/src/components/Select.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.js | ✅ |
| superset-frontend/packages/superset-ui-core/src/chart-composition/tooltip/TooltipTable.tsx | ✅ |
| superset-frontend/packages/superset-ui-chart-controls/src/components/MetricOption.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/shared/components/VerifyCORS.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/DataTable/components/SelectPageSize.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/Styles.tsx | ✅ |
| superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx | ✅ |
| superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/TableCatalog.tsx | ✅ |
| superset-frontend/src/components/index.ts | ✅ |
| superset-frontend/src/explore/components/controls/ZoomConfigControl/ZoomConfigControl.tsx | ✅ |
| superset-frontend/packages/superset-ui-chart-controls/src/components/ControlHeader.tsx | ✅ |
| superset-frontend/src/features/annotationLayers/AnnotationLayerModal.tsx | ✅ |
| superset-frontend/src/features/cssTemplates/CssTemplateModal.tsx | ✅ |
| superset-frontend/src/features/databases/DatabaseModal/ModalHeader.tsx | ✅ |
| superset-frontend/src/features/reports/ReportModal/index.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx | ✅ |
| superset-frontend/src/explore/components/PropertiesModal/index.tsx | ✅ |
| superset-frontend/src/features/rls/RowLevelSecurityModal.tsx | ✅ |
| superset-frontend/src/components/ListView/ListView.tsx | ✅ |
| superset-frontend/src/dashboard/components/PropertiesModal/index.tsx | ✅ |
| superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx | ✅ |
| superset-frontend/src/features/alerts/AlertReportModal.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
msyavuz
reviewed
May 9, 2025
superset-frontend/packages/superset-ui-chart-controls/src/components/ControlHeader.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/packages/superset-ui-demo/storybook/shared/components/Expandable.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/ZoomConfigControl/ZoomConfigControl.tsx
Outdated
Show resolved
Hide resolved
mistercrunch
reviewed
May 9, 2025
| @@ -17,5 +17,4 @@ | |||
| * under the License. | |||
| */ | |||
|
|
|||
| export { Dropdown } from 'antd'; | |||
| export type { DropDownProps } from 'antd/lib/dropdown'; | |||
| export { Dropdown, type DropDownProps } from 'antd-v5'; | |||
There was a problem hiding this comment.
is the plan to use what's in src/components once we move it to @superset-ui/core ?
There was a problem hiding this comment.
wondering what effect it may have on bundle sizes until we move things around ...
geido
reviewed
May 12, 2025
| // eslint-disable-next-line no-restricted-imports | ||
| import { Form, Tag } from 'antd'; // TODO: Remove antd | ||
| import { Form, Tag } from 'antd'; |
There was a problem hiding this comment.
Shouldn't these have been migrated to Ant Design 5 or at least keep the // TODO: Remove antd?
There was a problem hiding this comment.
Please follow this #33231 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The goal of this PR is to replace all remaining native HTML elements within the
superset-frontend/src,superset-frontend/plugins, andsuperset-frontend/packagesdirectories with their corresponding Ant Design 5 components.This change is being made to ensure that theming colors are applied consistently across all components in the project.
By replacing native HTML elements like
<input>,<table>,<button>,<li>, and<h3>/<h4>tags with Ant Design 5 components such asInput,Button,Typography.Title,andList.Item, we can guarantee that the Ant Design theming system works as expected.Specifically, this will:
Ensure consistent application of theming 🎨 (colors, fonts, spacing) across the UI.
Improve maintainability by aligning the entire codebase with the Ant Design 5 component system 🔧.
Ensure better responsiveness, theming, and accessibility 🌍 through the Ant Design 5 system.
Facilitate future UI enhancements, as the project will be fully based on Ant Design 5 components, making it easier to integrate new features or updates from the design system 🚀.
This PR can be considered a continuation of #33090, further extending the standardization and theming improvements across the project.
After this change, the theming colors and styles will work uniformly across all components, providing a consistent look and feel throughout the application.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION