Skip to content

refactor(ui): replace native HTML elements with Ant Design 5 components for consistent theming #33231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: template_less
Choose a base branch
from

Conversation

EnxDev
Copy link
Contributor

@EnxDev EnxDev commented Apr 24, 2025

SUMMARY

The goal of this PR is to replace all remaining native HTML elements within the superset-frontend/src, superset-frontend/plugins, and superset-frontend/packages directories with their corresponding Ant Design 5 components.

This change is being made to ensure that theming colors are applied consistently across all components in the project.
By replacing native HTML elements like <input>,<table>, <button>, <li>, and <h3>/<h4> tags with Ant Design 5 components such as Input, Button, Typography.Title, and List.Item, we can guarantee that the Ant Design theming system works as expected.

Specifically, this will:

Ensure consistent application of theming 🎨 (colors, fonts, spacing) across the UI.

Improve maintainability by aligning the entire codebase with the Ant Design 5 component system 🔧.

Ensure better responsiveness, theming, and accessibility 🌍 through the Ant Design 5 system.

Facilitate future UI enhancements, as the project will be fully based on Ant Design 5 components, making it easier to integrate new features or updates from the design system 🚀.

This PR can be considered a continuation of #33090, further extending the standardization and theming improvements across the project.

After this change, the theming colors and styles will work uniformly across all components, providing a consistent look and feel throughout the application.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  • The changes need to maintain the same appearance as before, and all tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Apr 24, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant