fix(heatmap): correctly render int and boolean falsy values on axes

[sfirke]

SUMMARY

Currently values of 0 and false on a heatmap axis render as <NULL>. This fixes that.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

Create a new dataset in SQL Lab like this and make a heatmap.

SELECT column1 as foo, column2 as bar, column3::boolean as is_active
FROM (VALUES 
    (0, 0, 't'),
    (1, 1, 'f'),
    (2, 2, 't'),
    (1, 0, 'f'),
    (0, 2, 't'),
    (2, 2, 'f')
) as t(column1, column2, column3);

ADDITIONAL INFORMATION

• Has associated issue: Heatmap y-axis sorting and rendering of 0 value #33105 - that is a two-part issue, this fixes one problem

[sfirke]

The heatmap y-axis sort is still broken, as noted in that issue. You can see that in the AFTER images still above.

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/transformProps.ts	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X