Skip to content

fix(histogram): remove extra single quotes #33248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Apr 25, 2025

SUMMARY

Those quotes shouldn't be there! Fixes #33246

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screenshot 2025-04-25 at 4 33 04 PM
After:
Screenshot 2025-04-25 at 4 32 39 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Apr 25, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@rusackas rusackas marked this pull request as ready for review April 25, 2025 16:51
@rusackas rusackas requested a review from srinify April 25, 2025 16:52
@dosubot dosubot bot added the viz:charts:histogram Related to the Histogram chart label Apr 25, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/Histogram/transformProps.ts

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@srinify
Copy link
Contributor

srinify commented Apr 25, 2025

@rusackas doesn't have to be this PR, but we may also want to update this README in the ECharts plugin folder. It's no longer just the Timeseries and Pie charts anymore: https://github.com/apache/superset/blob/05beb7cc4a5080f38a11fc377a5db7c910850919/superset-frontend/plugins/plugin-chart-echarts/README.md

@rusackas rusackas merged commit d2360b5 into master Apr 25, 2025
65 of 101 checks passed
@rusackas rusackas deleted the fix-histogrtam-quotes branch April 25, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histogram bin labels have extra pair of single quotes
2 participants